add support for top level as#288
Merged
escritorio-gustavo merged 3 commits intoAleph-Alpha:mainfrom Apr 2, 2024
Merged
Conversation
escritorio-gustavo
approved these changes
Apr 2, 2024
Contributor
escritorio-gustavo
left a comment
There was a problem hiding this comment.
LGTM! @NyxCode, do you want to change anything?
Collaborator
|
Hope you guys had a nice easter! I love it! Seems like a natural extension after supporting |
NyxCode
approved these changes
Apr 2, 2024
Contributor
Thanks! Hope you did as well! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal
This adds support for easily defining a struct or enum's type definition manually at the top level using the
as = ".."attribute. This is for symmetry with #286.Changes
Added type_as to the container attributes, and defined an early-returned implementation for if this attribute is specified
Checklist