Skip to content

Insert newline at end of generated files#321

Merged
escritorio-gustavo merged 5 commits intoAleph-Alpha:mainfrom
lucperkins:final-newline
May 22, 2024
Merged

Insert newline at end of generated files#321
escritorio-gustavo merged 5 commits intoAleph-Alpha:mainfrom
lucperkins:final-newline

Conversation

@lucperkins
Copy link
Copy Markdown
Contributor

@lucperkins lucperkins commented May 21, 2024

Goal

Closes #320

Changes

How did you go about solving the problem?

Checklist

  • I have followed the steps listed in the Contributing guide.
  • If necessary, I have added documentation related to the changes made.
  • I have added or updated the tests related to the changes made.

@lucperkins lucperkins changed the title Insert newline at end of file Insert newline at end of generated files May 21, 2024
Comment thread ts-rs/src/export.rs Outdated
Copy link
Copy Markdown
Contributor

@escritorio-gustavo escritorio-gustavo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread ts-rs/tests/integration/docs.rs Outdated
Copy link
Copy Markdown
Contributor

@escritorio-gustavo escritorio-gustavo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM + CI passes

@escritorio-gustavo escritorio-gustavo merged commit f898578 into Aleph-Alpha:main May 22, 2024
@escritorio-gustavo
Copy link
Copy Markdown
Contributor

Thanks for the PR @lucperkins!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: files are missing final newlines

2 participants