Linux: avoid converting uri-list to a String#197
Merged
complexspaces merged 2 commits into1Password:masterfrom Aug 2, 2025
Merged
Linux: avoid converting uri-list to a String#197complexspaces merged 2 commits into1Password:masterfrom
complexspaces merged 2 commits into1Password:masterfrom
Conversation
complexspaces
approved these changes
Aug 2, 2025
Member
complexspaces
left a comment
There was a problem hiding this comment.
This is a nice set of cleanup, thank you!
Member
|
This is now released in v3.6.1 on crates.io. Thanks again for the contribution, I marked it as a bugfix in the release notes since non-UTF8 paths are a completely valid use case to support. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not really needed, in addition if some of the paths contained non utf8 data we returned nothing.