Skip to content

bug(rig-1200): improve Client::builder DX#1436

Merged
joshua-mo-143 merged 2 commits intomainfrom
improve-client-builder-dx
Feb 25, 2026
Merged

bug(rig-1200): improve Client::builder DX#1436
joshua-mo-143 merged 2 commits intomainfrom
improve-client-builder-dx

Conversation

@FayCarsons
Copy link
Copy Markdown
Contributor

Removed recursive trait bounds between Provider and ProviderBuilder which confused type inference. Client builder also defaults to reqwest so that the Default bound is trivially solved, but instantiates the client lazily so that we do not have duplicate http client creation which can be expensive.

@linear
Copy link
Copy Markdown

linear Bot commented Feb 25, 2026

Copy link
Copy Markdown
Contributor

@joshua-mo-143 joshua-mo-143 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@joshua-mo-143 joshua-mo-143 added this pull request to the merge queue Feb 25, 2026
Merged via the queue into main with commit 2c786b7 Feb 25, 2026
6 checks passed
@github-actions github-actions Bot mentioned this pull request Feb 25, 2026
@FayCarsons FayCarsons deleted the improve-client-builder-dx branch February 25, 2026 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants