jetpack
Opened 13 years ago
Closed 13 years ago
#1717 closed defect (fixed)
Fix PHP warnings non-static method called dynamically
| Reported by: |
|
Owned by: |
|
|---|---|---|---|
| Priority: | normal | Severity: | normal |
| Plugin: | jetpack | Keywords: | php, logs, strict, e_strict, warning, static |
| Cc: |
Description
Several methods are not declared as static when they should be.
Example of content in PHP log:
(E_STRICT): Non-static method Jetpack_Notifications::init() should not be called statically
This is just noise in logs and can easily be avoided so more important issues can be spotted.
Attachments (1)
Change History (4)
#1
@
13 years ago
The attached patch tries to keep the changes to a minimum and inline with existing "public" and "static" declarations inside each individual class.
The classes don't seem to conform to a single standard for this.
#2
@
13 years ago
Also previously reported on the private Jetpack Beta Group blog: http://jetpackbetagroup.wordpress.com/2013/03/18/php-e_strict-error-for-moduleinit-function-calls-minor-thing-really/
Note: See
TracTickets for help on using
tickets.
Fixes logged PHP warnings and corrects several other static functions