Changeset 3423157

Version 1.3.6: Critical timezone fix for watchdog alerts + time validation

CRITICAL FIX:

• Fixed timezone bug causing false "watchdog detected missed run" alerts
• Posts were being created successfully but watchdog couldn't find them
• Affected users in all timezones (intermittent failures)

THE PROBLEM:

• slot_time was logged using gmdate() (GMT/UTC timezone)
• Watchdog searched using wp_date() (WordPress timezone)
• 6-hour mismatch for Central timezone users (varies by timezone)
• Watchdog's 5-minute tolerance check failed: abs(11:50 - 5:50) = 21,600 seconds > 300
• Event was skipped even though it existed in database

WHY IT WAS INTERMITTENT:

• Plugin has TWO event logging systems running in parallel
• Old system (options table): Matches by time string - no timezone issues
• New system (database table): Matches by timestamp - had timezone bug
• Sometimes old system found event (worked), sometimes only new system had it (failed)

THE SOLUTION:

• Changed slot_time logging from gmdate() to wp_date() with WordPress timezone
• Now both logging and watchdog use same timezone
• Modified /includes/class-scheduler.php line 173-175

BEFORE:

$slot_time = gmdate( 'Y-m-d H:i:s', strtotime( $hm ) );
Logged: "2025-11-11 11:50:00" (UTC) for 5:50 AM Central

AFTER:

$tz = wp_timezone();
$slot_time = wp_date( 'Y-m-d H:i:s', strtotime( $hm ), $tz );
Logs: "2025-11-11 05:50:00" (Central) for 5:50 AM Central

ADDITIONAL ENHANCEMENT:

• Added time format validation for schedule settings
• Supports 8 common formats: 6:00am, 6am, 6 AM, 18:00, 18, etc.
• Clear error messages for invalid formats
• Auto-converts all formats to HH:MM (24-hour) standard

VALIDATION EXAMPLES:

• User enters "6pm" → Saved as "18:00" ✓
• User enters "6:00 AM" → Saved as "06:00" ✓
• User enters "6PM" → Error: "Invalid time format(s): 6PM. Please use formats like '6:00am', '6:00 AM', '18:00', or '6pm'" ✗

TECHNICAL CHANGES:

• Modified /includes/class-scheduler.php: Fixed timezone in slot_time logging
• Modified /includes/class-admin.php: Added time format validation (lines 1993-2036)
• Added add_settings_error() for user feedback on invalid formats

BENEFITS:

• ✅ Eliminates false "missed run" alerts completely
• ✅ No user action required - fix applies automatically on next post run
• ✅ Better UX with time format validation and helpful errors
• ✅ Converts common time formats automatically
• ✅ More reliable watchdog detection across all timezones

COMPATIBILITY:

• Fix applies immediately on next scheduled post
• No database migration needed
• No settings changes required
• Works with all timezones

USER IMPACT:

• Users will stop receiving false watchdog alerts
• Clear feedback when entering schedule times in invalid formats
• More confidence in scheduled posting reliability