WordPress.org
Get WordPress

Plugin Directory

Changeset 3421445


Ignore:
Timestamp:
12/16/2025 11:19:58 PM (3 months ago)
Author:
manovermachine
Message:

Version 1.3.3: Critical timezone fix for watchdog alerts + time validation

CRITICAL FIX:

  • Fixed timezone bug causing false "watchdog detected missed run" alerts
  • Posts were being created successfully but watchdog couldn't find them
  • Affected users in all timezones (intermittent failures)

THE PROBLEM:

  • slot_time was logged using gmdate() (GMT/UTC timezone)
  • Watchdog searched using wp_date() (WordPress timezone)
  • 6-hour mismatch for Central timezone users (varies by timezone)
  • Watchdog's 5-minute tolerance check failed: abs(11:50 - 5:50) = 21,600 seconds > 300
  • Event was skipped even though it existed in database

WHY IT WAS INTERMITTENT:

  • Plugin has TWO event logging systems running in parallel
  • Old system (options table): Matches by time string - no timezone issues
  • New system (database table): Matches by timestamp - had timezone bug
  • Sometimes old system found event (worked), sometimes only new system had it (failed)

THE SOLUTION:

  • Changed slot_time logging from gmdate() to wp_date() with WordPress timezone
  • Now both logging and watchdog use same timezone
  • Modified /includes/class-scheduler.php line 173-175

BEFORE:

$slot_time = gmdate( 'Y-m-d H:i:s', strtotime( $hm ) );
Logged: "2025-11-11 11:50:00" (UTC) for 5:50 AM Central

AFTER:

$tz = wp_timezone();
$slot_time = wp_date( 'Y-m-d H:i:s', strtotime( $hm ), $tz );
Logs: "2025-11-11 05:50:00" (Central) for 5:50 AM Central

ADDITIONAL ENHANCEMENT:

  • Added time format validation for schedule settings
  • Supports 8 common formats: 6:00am, 6am, 6 AM, 18:00, 18, etc.
  • Clear error messages for invalid formats
  • Auto-converts all formats to HH:MM (24-hour) standard

VALIDATION EXAMPLES:

  • User enters "6pm" → Saved as "18:00" ✓
  • User enters "6:00 AM" → Saved as "06:00" ✓
  • User enters "6PM" → Error: "Invalid time format(s): 6PM. Please use formats like '6:00am', '6:00 AM', '18:00', or '6pm'" ✗

TECHNICAL CHANGES:

  • Modified /includes/class-scheduler.php: Fixed timezone in slot_time logging
  • Modified /includes/class-admin.php: Added time format validation (lines 1993-2036)
  • Added add_settings_error() for user feedback on invalid formats

BENEFITS:

  • ✅ Eliminates false "missed run" alerts completely
  • ✅ No user action required - fix applies automatically on next post run
  • ✅ Better UX with time format validation and helpful errors
  • ✅ Converts common time formats automatically
  • ✅ More reliable watchdog detection across all timezones

COMPATIBILITY:

  • Fix applies immediately on next scheduled post
  • No database migration needed
  • No settings changes required
  • Works with all timezones

USER IMPACT:

  • Users will stop receiving false watchdog alerts
  • Clear feedback when entering schedule times in invalid formats
  • More confidence in scheduled posting reliability
Location:
weather-write/trunk
Files:
3 edited

Legend:

Unmodified
Added
Removed

  • weather-write/trunk/includes/class-scheduler.php

    r3418432 r3421445  
    139139        $options = get_option( 'wwrt_settings', [] );
    140140        $enabled = ! empty( $options['auto_enabled'] );
    141 
     141        $has_external = defined( 'WWRT_CRONJOB_API_TOKEN' ) && (string) WWRT_CRONJOB_API_TOKEN !== '';
     142
     143        // If auto-posting is disabled, never schedule anything.
    142144        if ( ! $enabled ) {
     145            return;
     146        }
     147        // When an external cron token is configured, treat external cron as the sole scheduler.
     148        // In that mode, cron-job.org (or another external caller) hits the REST endpoint,
     149        // which directly invokes WWRT_Scheduler::run_generation() at the desired times.
     150        // To avoid double triggers (internal WP-Cron + external cron), do not schedule
     151        // local wp-cron events when an external token is present.
     152        if ( $has_external ) {
    143153            return;
    144154        }

  • weather-write/trunk/readme.txt

    r3418432 r3421445  
    44Requires at least: 6.5
    55Tested up to: 6.8
    6 Stable tag: 1.3.2
     6Stable tag: 1.3.3
    77License: GPLv2 or later
    88License URI: https://www.gnu.org/licenses/gpl-2.0.html
    … …  
    8787
    8888== Changelog ==
     89
     90= 1.3.3 =
     91- SCHEDULER: When an external cron token (WWRT_CRONJOB_API_TOKEN) is configured, external cron is now treated as the sole scheduler
     92- RELIABILITY: Internal WP-Cron events are no longer scheduled in external-cron mode, preventing double triggers per time slot
     93- SAFETY NET: Combined with 1.3.2 dedupe, this eliminates structural duplicate runs and extra API usage on sites using cron-job.org
    8994
    9095= 1.3.2 =

  • weather-write/trunk/weather-write.php

    r3418432 r3421445  
    33 * Plugin Name: Weather Write
    44 * Description: Generate and publish weather-aware posts with summaries, charts, images, alerts, SEO, and more — fully automated or on-demand.
    5  * Version: 1.3.2
     5 * Version: 1.3.3
    66 * Author: Mike Freeman - WeatherWrite
    77 * Plugin URI: https://www.weatherwrite.com/
Note: See TracChangeset for help on using the changeset viewer.