Details
Diff Detail
- Repository
- rMOZILLACENTRAL mozilla-central
Event Timeline
This looks fine to me, but do you plan to squash this with other commits on landing?
Also the change to third_party/rust/nom technically is only there because of an erroneous previous change, I left a comment at https://bugzilla.mozilla.org/show_bug.cgi?id=1628459#c4 about that. That change may disappear if that file gets readded by somebody else before you land this patch.
This looks fine to me, but do you plan to squash this with other commits on landing?
Not, actually.
I reverted the 3rd party nom changes.
The latest version still has the nom/.travis.yml file which would need to be removed as well.
- Update WR dependencies and tidy manifest
https://treeherder.mozilla.org/#/jobs?repo=try&revision=21ea00c7e11b39f08f7f251fe5afec019c9cf5fa
Your last try push has a build failure, looks like smallvec 1.3.0 takes a Range parameter to drain now. Since you've upgraded dependencies in webrender/Cargo.toml you'll also need to update the root (gecko) lockfile to pick that up by running cargo update -p webrender -p webrender_api. And of course add a range to the Smallvec::drain call.
your last try push is still showing some bustage. on my phone atm so I can't really dig into it.
I was trying to update everything to latest winit/glutin, but that turned out to be too much work, and I didn't roll back to the proper versions.
Good thing we have tries! Let's see if it's better this time ;)