Page MenuHomePhabricator

Bug 1178765 - Part 1: Add backdrop-filter WebRender display items r?gw
ClosedPublic

Authored by cbrewster on Jul 23 2019, 9:00 PM.
Tags
None
Referenced Files
F68015097: D39097.1776723366.diff
Sun, Apr 19, 10:16 PM
Unknown Object (File)
Thu, Apr 9, 9:56 AM
Unknown Object (File)
Feb 6 2026, 5:30 AM
Unknown Object (File)
Oct 15 2025, 5:11 AM
Unknown Object (File)
Oct 15 2025, 1:24 AM
Unknown Object (File)
Oct 13 2025, 10:15 PM
Unknown Object (File)
Oct 9 2025, 9:27 AM
Unknown Object (File)
Jun 23 2025, 12:09 PM
Subscribers
None

Diff Detail

Event Timeline

phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".
phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".
phab-bot removed a project: secure-revision.
cbrewster retitled this revision from Bug 1178765: Part 1 - Add backdrop-filter WebRender display items to Bug 1178765: Part 1 - Add backdrop-filter WebRender display items r?gw.Jul 25 2019, 10:06 PM
gw requested changes to this revision.Jul 28 2019, 8:02 PM
gw added inline comments.
gfx/webrender_bindings/src/bindings.rs
2088

Let's add a link in the comment here to the spec describing what a backdrop root is.

gfx/wr/webrender_api/src/display_item.rs
108

It's not clear to me that we want / need to expose the capture as part of the public API. I haven't read the rest of the patch yet, but it seems like this should be an internal implementation detail?

This revision now requires changes to proceed.Jul 28 2019, 8:02 PM
gfx/wr/webrender_api/src/display_item.rs
108

The original reason was because the backdrop capture/filter may need to be in different places in the display list. For example, if an element has opacity applied, it forms a backdrop root. We need to make sure to capture before the backdrop root is pushed, but the filter must be pushed after the opacity stacking context is pushed so the opacity applies to the filtered backdrop.

Since I am explicitly pushing a backdrop root stacking context from Gecko and not trying to infer in WebRender, I think I can probably merge capture/filter into a single item or just add it as parameters to stacking context.

This revision is now accepted and ready to land.Aug 1 2019, 11:02 PM
cbrewster retitled this revision from Bug 1178765: Part 1 - Add backdrop-filter WebRender display items r?gw to Bug 1178765 - Part 1: Add backdrop-filter WebRender display items r?gw.Aug 12 2019, 8:13 PM