Details
- Reviewers
smaug aleiserson - Group Reviewers
webgpu-reviewers Restricted Project webidl - Commits
- rFIREFOXAUTOLAND902def36332a: Bug 2031993 - Update `wgpu` to revision 0b4bdaf9cea213ce614405a834ff049b9dfba10…
- Bugzilla Bug ID
- 2031993
Diff Detail
- Repository
- rFIREFOXAUTOLAND firefox-autoland
- Build Status
Buildable 951092 Build 1051963: arc lint + arc unit
Event Timeline
Code analysis found 5 defects in diff 1250868:
- 1 defect found by cargo-audit (Mozlint)
- 4 defects found by clang-format (Mozlint)
You can run this analysis locally with:
- ./mach lint --warnings --outgoing
If you see a problem in this automated review, please report it here.
You can view these defects in the Diff Detail section of Phabricator diff 1250868.
The cargo-audit warning about rand is unrelated (and my conclusion when I looked last week was that the unsoundness doesn't affect Firefox), but the clang-format warnings seem worth fixing.
| dom/webgpu/RenderBundleEncoder.h | ||
|---|---|---|
| 79–80 | (and also for render passes) | |
| third_party/rust/wgpu-types/src/render.rs | ||
| 743 | There is a check in wgpu_bindings::command::replay_render_pass that blocks LoadOpDontCare, that maybe could be removed now, although I might keep it as relatively cheap insurance. Even if we do keep it, it's worth updating the comment "Explicitly forbid LoadOp::DontCare, until wgpu#8780 is resolved." to be clear that it is intentionally kept as insurance. | |
| third_party/rust/wgpu-types/src/render.rs | ||
|---|---|---|
| 743 | I updated the comment. Ideally we should have this behind a native only feature and wgpu-core should validate that it's not used unless the feature is enabled. I opened https://github.com/gfx-rs/wgpu/issues/9436. | |
Code analysis found 4 defects in diff 1251808:
- 1 defect found by cargo-audit (Mozlint)
- 3 defects found by clang-format (Mozlint)
You can run this analysis locally with:
- ./mach lint --warnings --outgoing
If you see a problem in this automated review, please report it here.
You can view these defects in the Diff Detail section of Phabricator diff 1251808.