Page MenuHomePhabricator
Differential D290901

Bug 2024601 - patch 1 - Parsing support for substitution functions as style query expression values. r=#style
ClosedPublic
Actions

Authored by jfkthame on Mar 30 2026, 2:23 PM.
Tags
Referenced Files
Unknown Object (File)
Sun, May 3, 12:14 AM
Unknown Object (File)
Thu, Apr 30, 9:24 AM
Unknown Object (File)
Sun, Apr 26, 12:56 PM
Unknown Object (File)
Thu, Apr 23, 5:59 PM
Unknown Object (File)
Fri, Apr 17, 11:45 AM
Unknown Object (File)
Fri, Apr 17, 5:32 AM
Unknown Object (File)
Thu, Apr 16, 10:29 PM
Unknown Object (File)
Thu, Apr 16, 6:01 AM
View All 21 Files
Subscribers
emilio
zrhoffman

Details

Reviewers
emilio
Group Reviewers
Restricted Project
Commits
rFIREFOXAUTOLANDa17f99d73967: Bug 2024601 - patch 1 - Parsing support for substitution functions as style…
rFIREFOXAUTOLANDc901771e872d: Bug 2024601 - patch 1 - Parsing support for substitution functions as style…
rFIREFOXAUTOLAND76ede91756ae: Bug 2024601 - patch 1 - Parsing support for substitution functions as style…
Bugzilla Bug ID
2024601
Summary

This is sufficient to make the existing parsing test pass, but the functions don't
actually work at evaluation time. The following patch will add some query evaluation
tests to expose this.

Diff Detail

Event Timeline

jfkthame created this revision.Mar 30 2026, 2:23 PM
Herald added a project: secure-revision. · View Herald TranscriptMar 30 2026, 2:23 PM
phab-bot published this revision for review.Mar 30 2026, 2:24 PM
phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".
phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".
phab-bot removed a project: secure-revision.
Herald added a subscriber: zrhoffman. · View Herald TranscriptMar 30 2026, 2:24 PM
jfkthame added a child revision: D290903: Bug 2024601 - patch 2 - Add evaluation tests involving substitution functions. r=#style.Mar 30 2026, 2:24 PM
emilio accepted this revision.Mar 30 2026, 2:32 PM
emilio added a project: testing-approved.
emilio added a subscriber: emilio.
emilio added inline comments.
servo/components/style/queries/feature_expression.rs
818–821

Maybe also env? In fact, maybe factor out this into a static function?

This revision is now accepted and ready to land.Mar 30 2026, 2:32 PM
Harbormaster completed remote builds in B938728: Diff 1236595.Mar 30 2026, 2:49 PM
jfkthame added inline comments.Mar 30 2026, 6:09 PM
servo/components/style/queries/feature_expression.rs
818–821

I wondered about supporting env() ... AFAIK there's not currently any test coverage for it, but I'll check whether webkit/blink accept it already. I guess there probably no good reason not to allow it.

jfkthame updated this revision to Diff 1236875.Mar 30 2026, 6:10 PM
Harbormaster completed remote builds in B938940: Diff 1236875.Mar 30 2026, 6:40 PM
jfkthame updated this revision to Diff 1237655.Mar 31 2026, 12:49 PM
jfkthame marked an inline comment as done.
Harbormaster completed remote builds in B939463: Diff 1237655.Mar 31 2026, 1:14 PM
Closed by commit rFIREFOXAUTOLAND76ede91756ae: Bug 2024601 - patch 1 - Parsing support for substitution functions as style… (authored by jfkthame, committed by jkew@mozilla.com <jkew@mozilla.com>). · Explain WhyApr 1 2026, 12:05 AM
This revision was automatically updated to reflect the committed changes.
jkew@mozilla.com <jkew@mozilla.com> added a commit: rFIREFOXAUTOLAND76ede91756ae: Bug 2024601 - patch 1 - Parsing support for substitution functions as style….
agoloman reopened this revision.Apr 1 2026, 12:43 AM
This revision is now accepted and ready to land.Apr 1 2026, 12:43 AM
agoloman added a reverting change: rFIREFOXAUTOLAND58ee6807ff33: Revert "Bug 2024601 - patch 6 - Also support env(), and add a couple tests for….Apr 1 2026, 12:43 AM
jfkthame updated this revision to Diff 1238598.Apr 1 2026, 9:19 AM
This revision was landed with ongoing or failed builds.Apr 1 2026, 9:38 AM
Closed by commit rFIREFOXAUTOLANDc901771e872d: Bug 2024601 - patch 1 - Parsing support for substitution functions as style… (authored by jfkthame, committed by jkew@mozilla.com <jkew@mozilla.com>). · Explain Why
This revision was automatically updated to reflect the committed changes.
jkew@mozilla.com <jkew@mozilla.com> added a commit: rFIREFOXAUTOLANDc901771e872d: Bug 2024601 - patch 1 - Parsing support for substitution functions as style….
Harbormaster completed remote builds in B940168: Diff 1238598.Apr 1 2026, 9:54 AM
sstanca reopened this revision.Apr 1 2026, 11:03 AM
This revision is now accepted and ready to land.Apr 1 2026, 11:03 AM
sstanca added a reverting change: rFIREFOXAUTOLAND42e52ce108ca: Revert "Bug 2024601 - patch 6 - Also support env(), and add a couple tests for….Apr 1 2026, 11:03 AM
Closed by commit rFIREFOXAUTOLANDa17f99d73967: Bug 2024601 - patch 1 - Parsing support for substitution functions as style… (authored by jfkthame, committed by jkew@mozilla.com <jkew@mozilla.com>). · Explain WhyApr 2 2026, 1:57 PM
This revision was automatically updated to reflect the committed changes.
jkew@mozilla.com <jkew@mozilla.com> added a commit: rFIREFOXAUTOLANDa17f99d73967: Bug 2024601 - patch 1 - Parsing support for substitution functions as style….
jkew@mozilla.com <jkew@mozilla.com> mentioned this in rFIREFOXBETA76ede91756ae: Bug 2024601 - patch 1 - Parsing support for substitution functions as style….Mon, Apr 20, 1:00 PM
jkew@mozilla.com <jkew@mozilla.com> mentioned this in rFIREFOXBETAc901771e872d: Bug 2024601 - patch 1 - Parsing support for substitution functions as style….
jkew@mozilla.com <jkew@mozilla.com> mentioned this in rFIREFOXBETAa17f99d73967: Bug 2024601 - patch 1 - Parsing support for substitution functions as style….Mon, Apr 20, 1:08 PM

Revision Contents
Changeset List

PathSizeCoverage (All)Coverage (Touched)
servo/
components/
style/
queries/
37 lines88%
Loading...
testing/
web-platform/
meta/
css/
css-conditional/
container-queries/
1 line--
--

Diff 1239968

View Options

servo/components/style/queries/feature_expression.rs

Loading...
View Options

testing/web-platform/meta/css/css-conditional/container-queries/__dir__.ini

Loading...
View Options

testing/web-platform/meta/css/css-conditional/container-queries/at-container-style-parsing.html.ini

Loading...
Privacy · Cookies · Legal