The color-mix() function can now take multiple color/percentage pairs
and mix them all together using the new algorithm.
Tests for the serialization is pending here:
https://github.com/web-platform-tests/wpt/pull/57234
Details
Details
- Reviewers
dshin - Group Reviewers
layout-reviewers Restricted Project - Commits
- rFIREFOXAUTOLAND999f556695d6: Bug 2007772 - Parse multiple items for color-mix() function r=layout-reviewers…
- Bugzilla Bug ID
- 2007772
Diff Detail
Diff Detail
- Repository
- rFIREFOXAUTOLAND firefox-autoland
- Build Status
Buildable 904265 Build 1005387: arc lint + arc unit
Event Timeline
Comment Actions
: As in comment, pending WPT approval & sync (But seems reasonable enough)
| servo/components/style/values/generics/color.rs | ||
|---|---|---|
| 111 | Hm, what should color-mix(red 40%, green 40%, blue 40%) serialize to? | |
| 170 | Oh, I guess for color-mix(red 40%, green 40%, blue 40%) this should be false | |
| servo/components/style/values/specified/color.rs | ||
| 97 | Worth linking https://drafts.csswg.org/css-values-5/#normalize-mix-percentages, I think | |
| 829 | This loop seems repeated at multiple places - maybe can map() into collect(), but that's probably a style thing. | |
| servo/components/style/values/generics/color.rs | ||
|---|---|---|
| 111 | color-mix(red 40%, green 40%, blue 40%), because normalized percentages doesn't add up to 1.0. | |
| servo/components/style/values/specified/color.rs | ||
| 829 | item.color.to_computed_color(context) returns an Option<_> and if one of them fails, the whole thing should fail. Don't think there is a cleaner way for that. | |
Comment Actions
Added functionality behind a pref layout.css.color-mix-multi-color.enabled, because the tests did not land yet.