Paths

Table of Contentst

Differential D275361

Bug 2004191 - Update WebDriver navigation to retain URL on navigation-committed event. r=jdescottes
ClosedPublic
Actions

Authored by sajidanwar on Dec 6 2025, 6:21 PM.

Tags

Referenced Files

	Unknown Object (File)
	Tue, Dec 30, 9:04 AM

	Unknown Object (File)
	Mon, Dec 29, 8:54 PM

	Unknown Object (File)
	Mon, Dec 29, 8:42 PM

	Unknown Object (File)
	Sat, Dec 27, 9:37 AM

	Unknown Object (File)
	Sat, Dec 27, 3:34 AM

	Unknown Object (File)
	Wed, Dec 24, 5:54 PM

	Unknown Object (File)
	Wed, Dec 24, 5:54 PM

	Unknown Object (File)
	Fri, Dec 19, 8:54 PM

View All 11 Files

Subscribers

webdriver-reviewers-rotation

Details

Reviewers

Commits

rFIREFOXAUTOLAND2cc27953b96f: Bug 2004191 - Update WebDriver navigation to retain URL on navigation-committed…

Bugzilla Bug ID

Diff Detail

Repository: rFIREFOXAUTOLAND firefox-autoland

Event Timeline

sajidanwar created this revision.Dec 6 2025, 6:21 PM

Herald added a project: secure-revision. · View Herald TranscriptDec 6 2025, 6:21 PM

Herald added a reviewer: webdriver-reviewers-rotation. · View Herald Transcript

Herald added a reviewer: webdriver-reviewers-rotation. · View Herald Transcript

phab-bot published this revision for review.Dec 6 2025, 6:22 PM

phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".

phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".

phab-bot removed a project: secure-revision.

phab-bot removed a reviewer: webdriver-reviewers-rotation.

phab-bot added a subscriber: webdriver-reviewers-rotation.

Harbormaster completed remote builds in B884454: Diff 1168315.Dec 6 2025, 6:41 PM

Thanks! One small suggestion for the test, but otherwise looks great! I pushed with the remote protocol "preset" (that's mach try --preset remote-protocol) at https://treeherder.mozilla.org/jobs?repo=try&landoCommitID=167690
(should be fine, I ran a similar patch through try a few days ago)

remote/shared/test/xpcshell/test_Navigate.js
700–723	question: I imagine you used `TARGET_URI_WITH_HASH` to make sure we are taking the url from the event and not the one which might be already set in the webprogress? Maybe create a TARGET_URI_FROM_NAVIGATION_COMMITTED variable with a slightly different url, to make it completely obvious?

This revision is now accepted and ready to land.Dec 8 2025, 9:51 AM

sajidanwar updated this revision to Diff 1168736.Dec 8 2025, 2:51 PM

sajidanwar marked an inline comment as done.Dec 8 2025, 2:53 PM

sajidanwar added inline comments.

remote/shared/test/xpcshell/test_Navigate.js
700–723	Good idea, updated in the new revision!

Harbormaster completed remote builds in B884808: Diff 1168736.Dec 8 2025, 3:03 PM

Perfect! I will land your patch now.

Closed by commit rFIREFOXAUTOLAND2cc27953b96f: Bug 2004191 - Update WebDriver navigation to retain URL on navigation-committed… (authored by sajidanwar, committed by jdescottes). · Explain WhyDec 9 2025, 2:02 AM

This revision was automatically updated to reflect the committed changes.

jdescottes added a commit: rFIREFOXAUTOLAND2cc27953b96f: Bug 2004191 - Update WebDriver navigation to retain URL on navigation-committed….

sajidanwar mentioned this in D275621: Bug 2004191 - Update WebDriver navigation to retain URL on navigation-committed event..Dec 9 2025, 2:20 PM

rvandermeulen@mozilla.com <rvandermeulen@mozilla.com> mentioned this in rFIREFOXBETAe8dda0d76690: Bug 2004191 - Update WebDriver navigation to retain URL on navigation-committed….Dec 9 2025, 3:56 PM

rvandermeulen@mozilla.com <rvandermeulen@mozilla.com> mentioned this in rFIREFOXRELEASEe8dda0d76690: Bug 2004191 - Update WebDriver navigation to retain URL on navigation-committed….Mon, Jan 5, 8:03 PM

jdescottes mentioned this in rFIREFOXBETA2cc27953b96f: Bug 2004191 - Update WebDriver navigation to retain URL on navigation-committed….Mon, Jan 12, 1:21 PM

Revision Contents
Changeset List

Path

Size

remote/

shared/

Navigate.sys.mjs

3 lines

test/

xpcshell/

test_Navigate.js

15 lines

testing/

web-platform/

meta/

webdriver/

tests/

bidi/

browsing_context/

navigate/

navigate.py.ini

6 lines

Diff 1169168

remote/shared/Navigate.sys.mjs

Loading...

remote/shared/test/xpcshell/test_Navigate.js

Loading...

testing/web-platform/meta/webdriver/tests/bidi/browsing_context/navigate/navigate.py.ini

Loading...