Details

Reviewers

teoxoy
emilio

Group Reviewers

webgpu-reviewers
webidl

Commits

rFIREFOXAUTOLAND6ca0d081b345: Bug 1977612 - feat(webgpu): allow `GPUBuffer`s in `GPUBindingResource` r=webgpu…

Bugzilla Bug ID

1977612

Summary

This change to upstream IDL happened at gpuweb#5193. Test coverage was added in gpuweb/cts#4390.

Diff Detail

Repository

rFIREFOXAUTOLAND firefox-autoland

Build Status

Buildable 825002
Build 925530: arc lint + arc unit

Event Timeline

ErichDonGubler created this revision.Jul 17 2025, 3:59 AM

Herald added a project: secure-revision. · View Herald TranscriptJul 17 2025, 3:59 AM

phab-bot published this revision for review.Jul 17 2025, 3:59 AM

phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".

phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".

phab-bot removed a project: secure-revision.

Herald added a reviewer: webidl. · View Herald TranscriptJul 17 2025, 3:59 AM

There are WPT tests that cover this at webgpu:api,validation,createBindGroup:buffer,resource_state:*, and I've confirmed that these tests work for most cases now. However, they have other blockers for completing successfully (for validation around buffers in the destroyed state). Even sadder, these tests for the destroyed state do not have any subtest granularity exposed, though internally the CTS does. So, relevant coverage still FAILs for us, because of other sins we'll eventually fix. Sigh. 🙁

Harbormaster failed remote builds in B819392: Diff 1087782!Jul 17 2025, 4:00 AM

ErichDonGubler updated this revision to Diff 1087783.Jul 17 2025, 4:06 AM

ErichDonGubler edited the summary of this revision. (Show Details)

Harbormaster failed remote builds in B819393: Diff 1087783!Jul 17 2025, 4:06 AM

teoxoy accepted this revision.Jul 17 2025, 8:17 AM

emilio accepted this revision.Jul 17 2025, 9:38 AM

This revision is now accepted and ready to land.Jul 17 2025, 9:38 AM

This revision was landed with ongoing or failed builds.Jul 17 2025, 12:04 PM

Closed by commit rFIREFOXAUTOLAND6ca0d081b345: Bug 1977612 - feat(webgpu): allow `GPUBuffer`s in `GPUBindingResource` r=webgpu… (authored by ErichDonGubler). · Explain Why

This revision was automatically updated to reflect the committed changes.

ErichDonGubler added a commit: rFIREFOXAUTOLAND6ca0d081b345: Bug 1977612 - feat(webgpu): allow `GPUBuffer`s in `GPUBindingResource` r=webgpu….

ErichDonGubler mentioned this in rFIREFOXRELEASE6ca0d081b345: Bug 1977612 - feat(webgpu): allow `GPUBuffer`s in `GPUBindingResource` r=webgpu….Aug 11 2025, 2:47 PM