Details

Reviewers

• jgilbert

Bugzilla Bug ID

1642854

Diff Detail

Repository: rMOZILLACENTRAL mozilla-central
Branch: default

Event Timeline

stransky planned changes to this revision.Jan 6 2025, 1:58 PM

stransky created this revision.

Herald added a project: secure-revision. · View Herald TranscriptJan 6 2025, 1:58 PM

Harbormaster completed remote builds in B740947: Diff 965063.Jan 6 2025, 1:58 PM

phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".Jan 6 2025, 1:58 PM

phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".

phab-bot removed a project: secure-revision.

Herald added a reviewer: • jgilbert. · View Herald TranscriptJan 6 2025, 1:58 PM

Code analysis found 3 defects in diff 965063:

3 defects found by code coverage analysis

WARNING: Found 3 defects (warning level) that can be dismissed.

In our previous code coverage analysis run, we found some files which had no coverage and are being modified in this patch:
Should they have tests, or are they dead code?

You can file a bug blocking Bug 1415824 for untested files that should be tested.
You can file a bug blocking Bug 1415819 for untested files that should be removed.

If you see a problem in this automated review, please report it here.

You can view these defects in the Diff Detail section of Phabricator diff 965063.

stransky updated this revision to Diff 965420.Jan 6 2025, 11:29 PM

stransky retitled this revision from WIP: Bug 1642854 [WIP][Wayland] hdr patch v.18 to WIP: Bug 1642854 [WIP][Wayland] hdr patch v.19.

Harbormaster completed remote builds in B741194: Diff 965420.Jan 6 2025, 11:29 PM

stransky planned changes to this revision.Jan 6 2025, 11:29 PM

Code analysis found 3 defects in diff 965420:

3 defects found by code coverage analysis

WARNING: Found 3 defects (warning level) that can be dismissed.

In our previous code coverage analysis run, we found some files which had no coverage and are being modified in this patch:
Should they have tests, or are they dead code?

You can file a bug blocking Bug 1415824 for untested files that should be tested.
You can file a bug blocking Bug 1415819 for untested files that should be removed.

If you see a problem in this automated review, please report it here.

You can view these defects in the Diff Detail section of Phabricator diff 965420.

stransky requested review of this revision.Jan 11 2025, 11:47 AM

stransky updated this revision to Diff 967803.

stransky retitled this revision from WIP: Bug 1642854 [WIP][Wayland] hdr patch v.19 to Bug 1642854 [WIP][Wayland] hdr patch v.20.

Herald added a subscriber: emilio. · View Herald TranscriptJan 11 2025, 11:47 AM

Harbormaster completed remote builds in B742848: Diff 967803.Jan 11 2025, 11:47 AM

stransky planned changes to this revision.Jan 11 2025, 11:48 AM

stransky planned changes to this revision.Jan 12 2025, 6:31 PM

stransky updated this revision to Diff 967835.

stransky retitled this revision from Bug 1642854 [WIP][Wayland] hdr patch v.20 to WIP: Bug 1642854 [WIP][Wayland] hdr patch v.20.

Harbormaster completed remote builds in B742876: Diff 967835.Jan 12 2025, 6:31 PM

stransky planned changes to this revision.Jan 13 2025, 11:36 AM

stransky updated this revision to Diff 967963.

stransky retitled this revision from WIP: Bug 1642854 [WIP][Wayland] hdr patch v.20 to WIP: Bug 1642854 [WIP][Wayland] hdr patch v.21.

Harbormaster completed remote builds in B742970: Diff 967963.Jan 13 2025, 11:36 AM

stransky updated this revision to Diff 970064.Jan 16 2025, 1:06 PM

stransky retitled this revision from WIP: Bug 1642854 [WIP][Wayland] hdr patch v.21 to WIP: Bug 1642854 [WIP][Wayland] hdr patch v.22.

Harbormaster completed remote builds in B744514: Diff 970064.Jan 16 2025, 1:06 PM

stransky planned changes to this revision.Jan 16 2025, 1:06 PM

stransky planned changes to this revision.Jan 16 2025, 1:18 PM

stransky updated this revision to Diff 970068.

stransky retitled this revision from WIP: Bug 1642854 [WIP][Wayland] hdr patch v.22 to WIP: Bug 1642854 [WIP][Wayland] hdr patch v.23.

Harbormaster completed remote builds in B744518: Diff 970068.Jan 16 2025, 1:18 PM

Already implemented.

WIP: Bug 1642854 [WIP][Wayland] hdr patch v.23
AbandonedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 970068

gfx/config/gfxConfigManager.cpp

gfx/layers/NativeLayer.h

gfx/layers/NativeLayerWayland.h

gfx/layers/NativeLayerWayland.cpp

gfx/layers/SurfacePoolWayland.h

gfx/layers/SurfacePoolWayland.cpp

gfx/layers/opengl/DMABUFTextureHostOGL.cpp

gfx/webrender_bindings/RenderDMABUFTextureHost.h

gfx/webrender_bindings/RenderDMABUFTextureHost.cpp

gfx/webrender_bindings/RenderTextureHost.h

gfx/webrender_bindings/RenderTextureHostWrapper.h

gfx/webrender_bindings/RenderTextureHostWrapper.cpp

modules/libpref/init/StaticPrefList.yaml

widget/gtk/DMABufFormats.h

widget/gtk/DMABufFormats.cpp

widget/gtk/DMABufLibWrapper.h

widget/gtk/DMABufLibWrapper.cpp

widget/gtk/DMABufSurface.h

widget/gtk/DMABufSurface.cpp

widget/gtk/GtkCompositorWidget.cpp

widget/gtk/WaylandBuffer.h

widget/gtk/WaylandBuffer.cpp

widget/gtk/WaylandSurface.h

widget/gtk/WaylandSurface.cpp

widget/gtk/moz.build

widget/gtk/nsWaylandDisplay.h

widget/gtk/nsWaylandDisplay.cpp

WIP: Bug 1642854 [WIP][Wayland] hdr patch v.23AbandonedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 970068

gfx/config/gfxConfigManager.cpp

gfx/layers/NativeLayer.h

gfx/layers/NativeLayerWayland.h

gfx/layers/NativeLayerWayland.cpp

gfx/layers/SurfacePoolWayland.h

gfx/layers/SurfacePoolWayland.cpp

gfx/layers/opengl/DMABUFTextureHostOGL.cpp

gfx/webrender_bindings/RenderDMABUFTextureHost.h

gfx/webrender_bindings/RenderDMABUFTextureHost.cpp

gfx/webrender_bindings/RenderTextureHost.h

gfx/webrender_bindings/RenderTextureHostWrapper.h

gfx/webrender_bindings/RenderTextureHostWrapper.cpp

modules/libpref/init/StaticPrefList.yaml

widget/gtk/DMABufFormats.h

widget/gtk/DMABufFormats.cpp

widget/gtk/DMABufLibWrapper.h

widget/gtk/DMABufLibWrapper.cpp

widget/gtk/DMABufSurface.h

widget/gtk/DMABufSurface.cpp

widget/gtk/GtkCompositorWidget.cpp

widget/gtk/WaylandBuffer.h

widget/gtk/WaylandBuffer.cpp

widget/gtk/WaylandSurface.h

widget/gtk/WaylandSurface.cpp

widget/gtk/moz.build

widget/gtk/nsWaylandDisplay.h

widget/gtk/nsWaylandDisplay.cpp

WIP: Bug 1642854 [WIP][Wayland] hdr patch v.23
AbandonedPublic
Actions

Revision Contents
Changeset List