Paths

Table of Contentst

Differential D220899

Bug 1915798 - [wdspec] Add WebDriver BiDi tests to check queuing of actions.
ClosedPublic
Actions

Authored by whimboo on Sep 3 2024, 1:21 PM.

Tags

Referenced Files

	Unknown Object (File)
	Fri, Mar 6, 5:03 PM

	Unknown Object (File)
	Nov 13 2025, 4:28 PM

	Unknown Object (File)
	Nov 13 2025, 4:28 PM

	Unknown Object (File)
	Nov 12 2025, 5:34 PM

	Unknown Object (File)
	Nov 8 2025, 11:57 AM

	Unknown Object (File)
	Nov 8 2025, 11:57 AM

	Unknown Object (File)
	Nov 7 2025, 5:52 AM

	Unknown Object (File)
	Nov 7 2025, 5:52 AM

View All 70 Files

Subscribers

wpt-webdriver-watchers

Details

Reviewers

Group Reviewers

webdriver-reviewers-rotation

Commits

rMOZILLACENTRAL2c80eec70b9b: Bug 1915798 - [wdspec] Add WebDriver BiDi tests to check queuing of actions.
rMOZILLACENTRAL99755cd9107c: Bug 1915798 - [wdspec] Add WebDriver BiDi tests to check queuing of actions.
rMOZILLACENTRALd0e02650c62f: Bug 1915798 - [wdspec] Add WebDriver BiDi tests to check queuing of actions.
rMOZILLACENTRALc163aae0b922: Bug 1915798 - [wdspec] Add WebDriver BiDi tests to check queuing of actions.

Bugzilla Bug ID

Test Plan

Try build: https://treeherder.mozilla.org/jobs?repo=try&revision=83f36a241488fc8522c74a75139d211cb2791e42

Follow-up try build with fixes and an xpcshell test:
https://treeherder.mozilla.org/jobs?repo=try&revision=266ff88a2ec63a0c112587ec749970004ab228a0

Diff Detail

Repository: rMOZILLACENTRAL mozilla-central

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes

Herald added a project: secure-revision. · View Herald TranscriptSep 3 2024, 1:21 PM

Herald added a reviewer: webdriver-reviewers-rotation. · View Herald Transcript

Herald added a subscriber: wpt-webdriver-watchers. · View Herald Transcript

Harbormaster completed remote builds in B697784: Diff 908644.Sep 3 2024, 1:21 PM

phab-bot published this revision for review.Sep 3 2024, 1:21 PM

phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".

phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".

phab-bot removed a project: secure-revision.

whimboo added a child revision: D220900: Bug 1915798 - [remote] Add support for "Action queues" to sequencially perform actions without races..Sep 3 2024, 1:21 PM

Code analysis found 9 defects in diff 908644:

9 defects found by eslint (Mozlint)

IMPORTANT: Found 9 defects (error level) that must be fixed before landing.

You can run this analysis locally with:

./mach lint --warnings --outgoing

If you see a problem in this automated review, please report it here.

You can view these defects in the Diff Detail section of Phabricator diff 908644.

Pushed accidentally. It's not ready yet for review.

whimboo removed a child revision: D220900: Bug 1915798 - [remote] Add support for "Action queues" to sequencially perform actions without races..Sep 3 2024, 8:12 PM

whimboo edited parent revisions, added: D220900: Bug 1915798 - [remote] Add support for "Action queues" to sequencially perform actions without races.; removed: D220543: Bug 1904665 - [remote] Prepare the Remote Agent code base for parent process event dispatching..

review comments

Harbormaster completed remote builds in B698533: Diff 909605.Sep 5 2024, 8:08 AM

whimboo edited the test plan for this revision. (Show Details)Sep 5 2024, 8:13 AM

9 defects closed compared to the previous diff 908644.

If you see a problem in this automated review, please report it here.

fix wdspec tests for element origin retrieval

Harbormaster completed remote builds in B698555: Diff 909632.Sep 5 2024, 9:32 AM

Thanks, the new tests look great

testing/web-platform/tests/webdriver/tests/bidi/input/__init__.py
6	nitpick: Can you add documentation for the parameters?

This revision is now accepted and ready to land.Sep 5 2024, 12:26 PM

jdescottes added inline comments.Sep 5 2024, 12:28 PM

testing/web-platform/tests/webdriver/tests/bidi/input/__init__.py
6	question: Just noticed that all consumers pass include_mousemove = True, do we really need the parameter? If yes I would suggest to use named arguments when calling the method to avoid having having `add_mouse_listeners(bidi_session, context, True)` in tests which forces you to look at the helper to know what this `True` might be affecting.

whimboo edited the test plan for this revision. (Show Details)Sep 5 2024, 2:02 PM

review comments

Harbormaster completed remote builds in B698682: Diff 909813.Sep 5 2024, 2:02 PM

Code analysis found 4 defects in diff 909813:

4 defects found by eslint (Mozlint)

IMPORTANT: Found 4 defects (error level) that must be fixed before landing.

You can run this analysis locally with:

./mach lint --warnings --outgoing

If you see a problem in this automated review, please report it here.

You can view these defects in the Diff Detail section of Phabricator diff 909813.

whimboo planned changes to this revision.Sep 5 2024, 2:35 PM

whimboo marked 2 inline comments as done.

whimboo added inline comments.

testing/web-platform/tests/webdriver/tests/bidi/input/__init__.py
6	Good point. I will update the name and use a named argument. Note that I didn't add documentation given that we don't do that for helpers.

fix linter failures

This revision is now accepted and ready to land.Sep 5 2024, 2:40 PM

Harbormaster completed remote builds in B698737: Diff 909875.Sep 5 2024, 2:40 PM

updated expectation for pointer_pen.py

Harbormaster completed remote builds in B698747: Diff 909885.Sep 5 2024, 2:57 PM

review comments

Harbormaster completed remote builds in B699134: Diff 910282.Sep 6 2024, 10:20 AM

review comments

Harbormaster completed remote builds in B699136: Diff 910284.Sep 6 2024, 10:28 AM

linter fixes and re-enabling commented out tests

Harbormaster completed remote builds in B699147: Diff 910297.Sep 6 2024, 11:57 AM

Closed by commit rMOZILLACENTRALc163aae0b922: Bug 1915798 - [wdspec] Add WebDriver BiDi tests to check queuing of actions. (authored by whimboo). · Explain WhySep 6 2024, 1:06 PM

This revision was automatically updated to reflect the committed changes.

whimboo added a commit: rMOZILLACENTRALc163aae0b922: Bug 1915798 - [wdspec] Add WebDriver BiDi tests to check queuing of actions..

• noemi_erli reopened this revision.Sep 6 2024, 6:07 PM

This revision is now accepted and ready to land.Sep 6 2024, 6:07 PM

• noemi_erli added a reverting change: rMOZILLACENTRALaf6d5b1328c3: Backed out 5 changesets (bug 1915798, bug 1904665) for causing failures….Sep 6 2024, 6:07 PM

fix for drag and drop tests

Harbormaster completed remote builds in B699989: Diff 911333.Sep 9 2024, 9:08 PM

review comments

Harbormaster completed remote builds in B700209: Diff 911640.Sep 10 2024, 1:05 PM

Closed by commit rMOZILLACENTRALd0e02650c62f: Bug 1915798 - [wdspec] Add WebDriver BiDi tests to check queuing of actions. (authored by whimboo). · Explain WhySep 10 2024, 2:30 PM

This revision was automatically updated to reflect the committed changes.

whimboo added a commit: rMOZILLACENTRALd0e02650c62f: Bug 1915798 - [wdspec] Add WebDriver BiDi tests to check queuing of actions..

• tszentpeteri reopened this revision.Sep 10 2024, 5:33 PM

This revision is now accepted and ready to land.Sep 10 2024, 5:33 PM

• tszentpeteri added a reverting change: rMOZILLACENTRALc6d992bc9d9c: Backed out 5 changesets (bug 1915798, bug 1904665) for causing wpt failures….Sep 10 2024, 5:33 PM

extend test timeout for invalid.py

Harbormaster completed remote builds in B701596: Diff 913358.Sep 12 2024, 7:21 PM

Closed by commit rMOZILLACENTRAL99755cd9107c: Bug 1915798 - [wdspec] Add WebDriver BiDi tests to check queuing of actions. (authored by whimboo). · Explain WhySep 13 2024, 7:58 AM

This revision was automatically updated to reflect the committed changes.

whimboo added a commit: rMOZILLACENTRAL99755cd9107c: Bug 1915798 - [wdspec] Add WebDriver BiDi tests to check queuing of actions..

ctuns reopened this revision.Sep 13 2024, 9:21 AM

This revision is now accepted and ready to land.Sep 13 2024, 9:21 AM

ctuns added a reverting change: rMOZILLACENTRAL1135a9c2def6: Backed out 6 changesets (bug 1915798, bug 1904665, bug 1918049) for causing wpt….Sep 13 2024, 9:21 AM

added fallback code with preference 'remote.events.async.enabled'

Harbormaster completed remote builds in B707126: Diff 920246.Sep 25 2024, 4:03 PM

Code analysis found 6 defects in diff 920246:

6 defects found by eslint (Mozlint)

IMPORTANT: Found 6 defects (error level) that must be fixed before landing.

You can run this analysis locally with:

./mach lint --warnings --outgoing

If you see a problem in this automated review, please report it here.

You can view these defects in the Diff Detail section of Phabricator diff 920246.

Several fixes

Harbormaster completed remote builds in B707942: Diff 921262.Sep 26 2024, 7:48 PM

review comments

Harbormaster completed remote builds in B708967: Diff 922562.Sep 30 2024, 8:20 PM

Closed by commit rMOZILLACENTRAL2c80eec70b9b: Bug 1915798 - [wdspec] Add WebDriver BiDi tests to check queuing of actions. (authored by whimboo). · Explain WhySep 30 2024, 8:44 PM

This revision was automatically updated to reflect the committed changes.

whimboo added a commit: rMOZILLACENTRAL2c80eec70b9b: Bug 1915798 - [wdspec] Add WebDriver BiDi tests to check queuing of actions..

Revision Contents
Changeset List

Path

Size

testing/

web-platform/

tests/

webdriver/

tests/

bidi/

input/

34 lines

perform_actions/

1 line

123 lines

release_actions/

126 lines

Diff 922578

testing/web-platform/tests/webdriver/tests/bidi/input/init.py

Loading...

testing/web-platform/tests/webdriver/tests/bidi/input/perform_actions/invalid.py

Loading...

testing/web-platform/tests/webdriver/tests/bidi/input/perform_actions/queue.py

Loading...

testing/web-platform/tests/webdriver/tests/bidi/input/release_actions/queue.py

Loading...