Page MenuHomePhabricator

Bug 1915798 - [wdspec] Add WebDriver BiDi tests to check queuing of actions.
ClosedPublic

Authored by whimboo on Sep 3 2024, 1:21 PM.
Referenced Files
Unknown Object (File)
Fri, Mar 6, 5:03 PM
Unknown Object (File)
Nov 13 2025, 4:28 PM
Unknown Object (File)
Nov 13 2025, 4:28 PM
Unknown Object (File)
Nov 12 2025, 5:34 PM
Unknown Object (File)
Nov 8 2025, 11:57 AM
Unknown Object (File)
Nov 8 2025, 11:57 AM
Unknown Object (File)
Nov 7 2025, 5:52 AM
Unknown Object (File)
Nov 7 2025, 5:52 AM

Diff Detail

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
phab-bot published this revision for review.Sep 3 2024, 1:21 PM
phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".
phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".
phab-bot removed a project: secure-revision.

Code analysis found 9 defects in diff 908644:

  • 9 defects found by eslint (Mozlint)
IMPORTANT: Found 9 defects (error level) that must be fixed before landing.

You can run this analysis locally with:

  • ./mach lint --warnings --outgoing

If you see a problem in this automated review, please report it here.

You can view these defects in the Diff Detail section of Phabricator diff 908644.

Pushed accidentally. It's not ready yet for review.

whimboo updated this revision to Diff 909605.

review comments

9 defects closed compared to the previous diff 908644.


If you see a problem in this automated review, please report it here.

fix wdspec tests for element origin retrieval

jdescottes added a project: testing-approved.
jdescottes added a subscriber: jdescottes.

Thanks, the new tests look great

testing/web-platform/tests/webdriver/tests/bidi/input/__init__.py
6

nitpick: Can you add documentation for the parameters?

This revision is now accepted and ready to land.Sep 5 2024, 12:26 PM
testing/web-platform/tests/webdriver/tests/bidi/input/__init__.py
6

question: Just noticed that all consumers pass include_mousemove = True, do we really need the parameter? If yes I would suggest to use named arguments when calling the method to avoid having having add_mouse_listeners(bidi_session, context, True) in tests which forces you to look at the helper to know what this True might be affecting.

Code analysis found 4 defects in diff 909813:

  • 4 defects found by eslint (Mozlint)
IMPORTANT: Found 4 defects (error level) that must be fixed before landing.

You can run this analysis locally with:

  • ./mach lint --warnings --outgoing

If you see a problem in this automated review, please report it here.

You can view these defects in the Diff Detail section of Phabricator diff 909813.

whimboo marked 2 inline comments as done.
whimboo added inline comments.
testing/web-platform/tests/webdriver/tests/bidi/input/__init__.py
6

Good point. I will update the name and use a named argument.

Note that I didn't add documentation given that we don't do that for helpers.

whimboo updated this revision to Diff 909875.
whimboo marked an inline comment as done.

fix linter failures

This revision is now accepted and ready to land.Sep 5 2024, 2:40 PM

updated expectation for pointer_pen.py

linter fixes and re-enabling commented out tests

This revision is now accepted and ready to land.Sep 6 2024, 6:07 PM

fix for drag and drop tests

This revision is now accepted and ready to land.Sep 10 2024, 5:33 PM

extend test timeout for invalid.py

This revision is now accepted and ready to land.Sep 13 2024, 9:21 AM

added fallback code with preference 'remote.events.async.enabled'

Code analysis found 6 defects in diff 920246:

  • 6 defects found by eslint (Mozlint)
IMPORTANT: Found 6 defects (error level) that must be fixed before landing.

You can run this analysis locally with:

  • ./mach lint --warnings --outgoing

If you see a problem in this automated review, please report it here.

You can view these defects in the Diff Detail section of Phabricator diff 920246.