Differential D211345

Bug 1887644 - [wdspec] Add a test for non-existent files for "input.setFiles" command.
ClosedPublic
Actions

Authored by Sasha on May 23 2024, 10:53 AM.

Tags

Referenced Files

	Unknown Object (File)
	Thu, Apr 30, 4:37 PM

	Unknown Object (File)
	Mon, Apr 27, 6:03 AM

	Unknown Object (File)
	Sat, Apr 25, 10:37 AM

	Unknown Object (File)
	Thu, Apr 23, 11:29 AM

	Unknown Object (File)
	Wed, Apr 22, 2:11 PM

	Unknown Object (File)
	Tue, Apr 21, 6:18 AM

	Unknown Object (File)
	Mon, Apr 20, 8:28 PM

	Unknown Object (File)
	Wed, Apr 15, 5:20 AM

View All 55 Files

Subscribers

wpt-webdriver-watchers

Details

Reviewers

Group Reviewers

webdriver-reviewers-rotation

Commits

rMOZILLACENTRAL6172cdacabda: Bug 1887644 - [wdspec] Add a test for non-existent files for "input.setFiles"…

Bugzilla Bug ID

Test Plan

https://treeherder.mozilla.org/jobs?repo=try&revision=405a7f5776c9992018d69e1bdcc8cfc7f4077107

Diff Detail

Repository: rMOZILLACENTRAL mozilla-central

Event Timeline

Sasha created this revision.May 23 2024, 10:53 AM

Herald added a project: secure-revision. · View Herald TranscriptMay 23 2024, 10:53 AM

Herald added a reviewer: webdriver-reviewers-rotation. · View Herald Transcript

Harbormaster completed remote builds in B663594: Diff 866064.May 23 2024, 10:53 AM

phab-bot published this revision for review.May 23 2024, 10:53 AM

phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".

phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".

phab-bot removed a project: secure-revision.

Sasha edited the test plan for this revision. (Show Details)May 23 2024, 10:58 AM

whimboo requested changes to this revision.May 23 2024, 12:41 PM

whimboo added a subscriber: whimboo.

whimboo added inline comments.

testing/web-platform/mozilla/tests/webdriver/bidi/input/set_files/invalid.py
14 ↗	(On Diff #866064)	Do you remember if there will not be such an error with Chrome? Nevertheless we could still have this as a normal wdspec test and have a dedicated assertion per browser.

This revision now requires changes to proceed.May 23 2024, 12:41 PM

Sasha requested review of this revision.May 23 2024, 2:24 PM

Sasha updated this revision to Diff 866203.

Sasha retitled this revision from Bug 1887644 - Add gecko specific test for non-existent files for "input.setFiles" command. to Bug 1887644 - [wdspec] Add a test for non-existent files for "input.setFiles" command..

Herald added a subscriber: wpt-webdriver-watchers. · View Herald TranscriptMay 23 2024, 2:24 PM

Harbormaster completed remote builds in B663685: Diff 866203.May 23 2024, 2:24 PM

Sasha marked an inline comment as done.May 23 2024, 2:25 PM

Sasha added inline comments.

testing/web-platform/mozilla/tests/webdriver/bidi/input/set_files/invalid.py
14 ↗	(On Diff #866064)	Chrome doesn't throw in this case. I've created the wdspec test

Thanks! Sad to see that we don't have a consistent behavior here but I assume it will not change and clients have to handle the difference.

This revision is now accepted and ready to land.May 23 2024, 4:58 PM

Sasha marked an inline comment as done.May 24 2024, 7:26 AM

Closed by commit rMOZILLACENTRAL6172cdacabda: Bug 1887644 - [wdspec] Add a test for non-existent files for "input.setFiles"… (authored by Sasha). · Explain WhyMay 24 2024, 7:32 AM

This revision was automatically updated to reflect the committed changes.

Sasha added a commit: rMOZILLACENTRAL6172cdacabda: Bug 1887644 - [wdspec] Add a test for non-existent files for "input.setFiles"….

Revision Contents
Changeset List

Path

Size

testing/

web-platform/

tests/

webdriver/

tests/

bidi/

input/

set_files/

37 lines

Diff 866675

testing/web-platform/tests/webdriver/tests/bidi/input/set_files/files.py

Loading...