Page MenuHomePhabricator
Differential D210293

Bug 1894217 - [wdspec] Add more tests for "userContext" argument in "permissions.setPermission" command.
ClosedPublic
Actions

Authored by Sasha on May 14 2024, 12:22 PM.
Tags
Referenced Files
Unknown Object (File)
Tue, May 5, 3:52 PM
Unknown Object (File)
Sun, Apr 26, 6:11 AM
Unknown Object (File)
Tue, Apr 21, 12:27 PM
Unknown Object (File)
Tue, Apr 21, 4:54 AM
Unknown Object (File)
Tue, Apr 21, 12:11 AM
Unknown Object (File)
Mon, Apr 20, 10:41 AM
Unknown Object (File)
Mon, Apr 20, 2:05 AM
Unknown Object (File)
Jan 12 2026, 7:37 PM
View All 42 Files
Subscribers
whimboo
wpt-webdriver-watchers

Details

Reviewers
whimboo
Group Reviewers
webdriver-reviewers-rotation
Commits
rMOZILLACENTRAL9532fe565037: Bug 1894217 - [wdspec] Add more tests for "userContext" argument in…
Bugzilla Bug ID
1894217
Test Plan

https://treeherder.mozilla.org/jobs?repo=try&revision=1113d99a566ea74231fc568a7fb22d4a0860296e

Diff Detail

Event Timeline

Sasha created this revision.May 14 2024, 12:22 PM
Herald added a project: secure-revision. · View Herald TranscriptMay 14 2024, 12:22 PM
Herald added a reviewer: webdriver-reviewers-rotation. · View Herald Transcript
Herald added a subscriber: wpt-webdriver-watchers. · View Herald Transcript
Harbormaster completed remote builds in B659873: Diff 861684.May 14 2024, 12:22 PM
phab-bot published this revision for review.May 14 2024, 12:22 PM
phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".
phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".
phab-bot removed a project: secure-revision.
Sasha edited the test plan for this revision. (Show Details)May 14 2024, 12:25 PM
whimboo accepted this revision.May 15 2024, 8:27 AM
whimboo added a project: testing-approved.
whimboo added a subscriber: whimboo.

Thanks! We should have a good test coverage for user contexts now. Please take a look at the nit before landing.

testing/web-platform/tests/webdriver/tests/bidi/external/permissions/set_permission/user_context.py
12

nitpick: Maybe you could move this test up so that it's close to the other set permission tests and reset permission is not in the middle?

This revision is now accepted and ready to land.May 15 2024, 8:27 AM
Sasha updated this revision to Diff 862268.May 15 2024, 8:35 AM
Sasha marked an inline comment as done.
Harbormaster completed remote builds in B660343: Diff 862268.May 15 2024, 8:35 AM
Sasha added inline comments.May 15 2024, 8:36 AM
testing/web-platform/tests/webdriver/tests/bidi/external/permissions/set_permission/user_context.py
12

sure, updated

Sasha updated this revision to Diff 862289.May 15 2024, 8:51 AM
Harbormaster completed remote builds in B660350: Diff 862289.May 15 2024, 8:51 AM
Closed by commit rMOZILLACENTRAL9532fe565037: Bug 1894217 - [wdspec] Add more tests for "userContext" argument in… (authored by Sasha). · Explain WhyMay 15 2024, 10:57 AM
This revision was automatically updated to reflect the committed changes.
Sasha added a commit: rMOZILLACENTRAL9532fe565037: Bug 1894217 - [wdspec] Add more tests for "userContext" argument in….

Revision Contents
Changeset List

PathSize
testing/
web-platform/
meta/
webdriver/
tests/
bidi/
external/
permissions/
set_permission/
4 lines
12 lines
tests/
webdriver/
tests/
bidi/
external/
permissions/
set_permission/
38 lines
user_context.py
set_permission.py
195 lines

Diff 862375

View Options

testing/web-platform/meta/webdriver/tests/bidi/external/permissions/set_permission/set_permission.py.ini

Loading...
View Options

testing/web-platform/meta/webdriver/tests/bidi/external/permissions/set_permission/user_context.py.ini

Loading...
View Options

testing/web-platform/tests/webdriver/tests/bidi/external/permissions/set_permission/set_permission.py

Loading...
View Options

testing/web-platform/tests/webdriver/tests/bidi/external/permissions/set_permission/user_context.py

Loading...
Privacy · Cookies · Legal