Details

Reviewers

emilio

Commits

rMOZILLACENTRAL8ffd5fe0ee69: Bug 1805727 - Part 1: Support transition-behavior longhand in style. r=emilio

Bugzilla Bug ID

1805727

Summary

Add transition-behavior longhand property. This doesn't include layout
animation support.

Diff Detail

Repository

rMOZILLACENTRAL mozilla-central

Build Status

Buildable 631028
Build 729591: arc lint + arc unit

Event Timeline

only style (wip)

Herald added a project: secure-revision. · View Herald TranscriptFeb 2 2024, 3:05 AM

Harbormaster completed remote builds in B622871: Diff 817204.Feb 2 2024, 3:06 AM

boris added a child revision: D200409: Bug 1805727 - Part 2: Add transition-behavior to transition shorthand in style..Feb 2 2024, 3:06 AM

phab-bot published this revision for review.Feb 2 2024, 3:06 AM

phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".

phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".

phab-bot removed a project: secure-revision.

Herald added subscribers: zrhoffman, Dexter, emilio. · View Herald TranscriptFeb 2 2024, 3:06 AM

boris updated this revision to Diff 823308.Feb 14 2024, 8:22 PM

Harbormaster completed remote builds in B628022: Diff 823308.Feb 14 2024, 8:22 PM

boris added reviewers: layout-reviewers, Restricted Project.Feb 14 2024, 10:05 PM

Herald added a reviewer: devtools-reviewers. · View Herald TranscriptFeb 14 2024, 10:05 PM

emilio requested changes to this revision.Feb 14 2024, 10:13 PM

emilio added inline comments.

servo/components/style/properties/longhands/ui.mako.rs
211	Please remove the prefix. We don't want authors to be able to set `-moz-transition-behavior`.

This revision now requires changes to proceed.Feb 14 2024, 10:13 PM

nchevobbe removed a reviewer: devtools-reviewers.Feb 15 2024, 6:34 AM

Addressed comments

Harbormaster completed remote builds in B628344: Diff 823621.Feb 15 2024, 3:11 PM

boris marked an inline comment as done.Feb 15 2024, 3:12 PM

Thanks!

layout/style/test/property_database.js
14092	nit: If you write this using `Object.assign` then removing the pref means we can just move stuff around. But either way is fine

This revision is now accepted and ready to land.Feb 19 2024, 10:30 AM

Addressed comments

Harbormaster completed remote builds in B629829: Diff 825466.Feb 21 2024, 9:45 PM

boris removed reviewers: layout-reviewers, Restricted Project.Feb 23 2024, 9:23 PM

Addressed comments

Harbormaster completed remote builds in B630855: Diff 826707.Feb 23 2024, 9:24 PM

Rebased

Harbormaster completed remote builds in B630876: Diff 826741.Feb 23 2024, 9:41 PM

Closed by commit rMOZILLACENTRAL8ffd5fe0ee69: Bug 1805727 - Part 1: Support transition-behavior longhand in style. r=emilio (authored by boris). · Explain WhyFeb 23 2024, 9:47 PM

This revision was automatically updated to reflect the committed changes.

boris added a commit: rMOZILLACENTRAL8ffd5fe0ee69: Bug 1805727 - Part 1: Support transition-behavior longhand in style. r=emilio.

Harbormaster completed remote builds in B631028: Diff 826754.Feb 27 2024, 1:24 AM

Bug 1805727 - Part 1: Support transition-behavior longhand in style.
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 826754

devtools/server/actors/animation-type-longhand.js

dom/base/use_counter_metrics.yaml

layout/style/ServoBindings.toml

layout/style/nsStyleStruct.h

layout/style/nsStyleStruct.cpp

layout/style/test/mochitest.toml

layout/style/test/property_database.js

modules/libpref/init/StaticPrefList.yaml

servo/components/style/properties/gecko.mako.rs

servo/components/style/properties/longhands/ui.mako.rs

servo/components/style/values/computed/animation.rs

servo/components/style/values/computed/mod.rs

servo/components/style/values/specified/animation.rs

servo/components/style/values/specified/mod.rs

servo/ports/geckolib/cbindgen.toml

testing/web-platform/meta/css/css-transitions/dir.ini

testing/web-platform/meta/css/css-transitions/parsing/transition-behavior.html.ini

Bug 1805727 - Part 1: Support transition-behavior longhand in style.ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 826754

devtools/server/actors/animation-type-longhand.js

dom/base/use_counter_metrics.yaml

layout/style/ServoBindings.toml

layout/style/nsStyleStruct.h

layout/style/nsStyleStruct.cpp

layout/style/test/mochitest.toml

layout/style/test/property_database.js

modules/libpref/init/StaticPrefList.yaml

servo/components/style/properties/gecko.mako.rs

servo/components/style/properties/longhands/ui.mako.rs

servo/components/style/values/computed/animation.rs

servo/components/style/values/computed/mod.rs

servo/components/style/values/specified/animation.rs

servo/components/style/values/specified/mod.rs

servo/ports/geckolib/cbindgen.toml

testing/web-platform/meta/css/css-transitions/__dir__.ini

testing/web-platform/meta/css/css-transitions/parsing/transition-behavior.html.ini

Bug 1805727 - Part 1: Support transition-behavior longhand in style.
ClosedPublic
Actions

Revision Contents
Changeset List

testing/web-platform/meta/css/css-transitions/dir.ini