Page MenuHomePhabricator

Bug 1858006 - make installer auto-pin on Win 11 pre-UBR 2361 builds.
ClosedPublic

Authored by mhughes on Oct 12 2023, 8:59 PM.
Referenced Files
Unknown Object (File)
Sun, Jun 14, 2:56 PM
Unknown Object (File)
Sat, Jun 13, 6:04 PM
Unknown Object (File)
Sat, Jun 13, 6:04 PM
Unknown Object (File)
Wed, Jun 10, 7:18 PM
Unknown Object (File)
Mon, Jun 8, 12:55 AM
Unknown Object (File)
May 12 2026, 9:08 PM
Unknown Object (File)
May 12 2026, 8:15 PM
Unknown Object (File)
May 12 2026, 6:14 PM
Subscribers
Restricted Project

Details

Summary

The previous commits to shared.nsh resulted in auto-pinning only occurring in Windows 11 builds that weren't build number 22621 or higher, but a lot of users on Windows 11 are on 22621 already and the build number to pay attention to, when MS introduced the user confirmation for pinning popup, is in Windows 11, 22621, UBR 2361.
This commit checks for the UBR number too.

Test Plan

I modified the numbers locally and ran to confirm everything worked as expected.

I tested that the default flow doesn't trigger the system popup, and doesn't try to pin. And the custom flow doesn't show the option to pin in Setup.exe and doesn't try to pin.
I tested (by faking the numbers locally) that when the local UBR number is less than the 2361 number, the default flow does try to auto-pin and the custom flow gives the option to pin.

Diff Detail

Event Timeline

mhughes created this revision.
phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".Oct 12 2023, 8:59 PM
phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".
phab-bot removed a project: secure-revision.
mhughes added reviewers: nalexander, bhearsum.
mhughes added a subscriber: Restricted Project.
mhughes updated this revision to Diff 775105.
browser/installer/windows/nsis/shared.nsh
1308

This is wrong because UBR is not monotonic. The latest 21H2 build number is already 22000.2538. The latest Windows 10 build number is 19045.3570.

browser/installer/windows/nsis/shared.nsh
1308

But it checks first if the third number is less than 22621. If it's over 22621, it won't fall through to the "1" case.
So Windows 11, 22000.2538 would fall through and show the popup, but MS didn't introduce the new functionality until 22H2 (or 22H3, depending) which is the 22621 or greater.
No?

browser/installer/windows/nsis/shared.nsh
1308

I got it. Yes, this will be a problem. I'll fix it. Thanks.

mhughes updated this revision to Diff 775217.
mhughes marked an inline comment as done.
mhughes retitled this revision from WIP: Bug 1858006 - make installer auto-pin on Win 11 pre-UBR 2361 builds. to Bug 1858006 - make installer auto-pin on Win 11 pre-UBR 2361 builds..Oct 12 2023, 11:48 PM

testing-exception-elsewhere: in the installer, this requires manual testing.

This revision is now accepted and ready to land.Oct 12 2023, 11:55 PM