Page MenuHomePhabricator
Differential D172654

Bug 1821563 - Do not create a promise from an uncatchable exception r=smaug,mgaudet
ClosedPublic
Actions

Authored by saschanaz on Mar 15 2023, 9:48 AM.
Tags
Referenced Files
Unknown Object (File)
Sat, Jun 6, 9:50 PM
Unknown Object (File)
May 1 2026, 6:58 PM
Unknown Object (File)
May 1 2026, 9:55 AM
Unknown Object (File)
Apr 30 2026, 9:51 AM
Unknown Object (File)
Apr 27 2026, 1:35 AM
Unknown Object (File)
Apr 26 2026, 11:01 AM
Unknown Object (File)
Apr 16 2026, 11:13 PM
Unknown Object (File)
Apr 16 2026, 9:25 PM
View All 17 Files
Subscribers
reviewbot

Details

Reviewers
smaug
mgaudet
Commits
rMOZILLACENTRALe4d945ff95b3: Bug 1821563 - Do not create a promise from an uncatchable exception r=mgaudet…
rMOZILLACENTRAL703562db4aa2: Bug 1821563 - Do not create a promise from an uncatchable exception r=mgaudet
Bugzilla Bug ID
1821563

Diff Detail

Event Timeline

saschanaz created this revision.Mar 15 2023, 9:48 AM
Herald added a project: secure-revision. · View Herald TranscriptMar 15 2023, 9:48 AM
Harbormaster completed remote builds in B517306: Diff 693061.Mar 15 2023, 9:48 AM
phab-bot published this revision for review.Mar 15 2023, 9:48 AM
phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".
phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".
phab-bot removed a project: secure-revision.
saschanaz updated this revision to Diff 693068.Mar 15 2023, 10:10 AM
saschanaz retitled this revision from Bug 1821563 - Check pending exception before stealing r=smaug,mgaudet to Bug 1821563 - Do not create a promise from an uncatchable exception r=smaug,mgaudet.
Harbormaster completed remote builds in B517313: Diff 693068.Mar 15 2023, 10:10 AM
saschanaz updated this revision to Diff 693074.Mar 15 2023, 10:37 AM
Harbormaster completed remote builds in B517319: Diff 693074.Mar 15 2023, 10:37 AM
reviewbot added a subscriber: reviewbot.Mar 15 2023, 10:53 AM

2 issues closed compared to the previous diff 693068.

If you see a problem in this automated review, please report it here.

mgaudet accepted this revision.Mar 15 2023, 11:05 AM
mgaudet added a project: testing-approved.

I'm 90% sure I follow the test now... I think this all makes sense (and the solution looks correct too)

This revision is now accepted and ready to land.Mar 15 2023, 11:05 AM
saschanaz added a comment.Mar 15 2023, 11:13 AM
In D172654#5682749, @mgaudet wrote:

I'm 90% sure I follow the test now... I think this all makes sense (and the solution looks correct too)

Oh, I mostly copypasted the repro from the fuzzer report. Simplifying it further in case anyone hits it again...

saschanaz updated this revision to Diff 693097.Mar 15 2023, 11:14 AM
Harbormaster completed remote builds in B517339: Diff 693097.Mar 15 2023, 11:14 AM
Closed by commit rMOZILLACENTRAL703562db4aa2: Bug 1821563 - Do not create a promise from an uncatchable exception r=mgaudet (authored by saschanaz). · Explain WhyMar 15 2023, 2:46 PM
This revision was automatically updated to reflect the committed changes.
saschanaz added a commit: rMOZILLACENTRAL703562db4aa2: Bug 1821563 - Do not create a promise from an uncatchable exception r=mgaudet.
Harbormaster completed remote builds in B517889: Diff 693204.Mar 16 2023, 4:42 PM
saschanaz added a commit: rMOZILLACENTRALe4d945ff95b3: Bug 1821563 - Do not create a promise from an uncatchable exception r=mgaudet….Mar 17 2023, 2:12 PM
saschanaz mentioned this in D173026: Bug 1822675 - Part 2: Do not reject with uncatchable exception r=smaug.Mar 20 2023, 2:46 PM

Revision Contents
Changeset List

PathSizeCoverage (All)Coverage (Touched)
dom/
streams/
4 lines91%
Loading...
testing/
web-platform/
tests/
encoding/
streams/
20 lines--

Diff 693204

View Options

dom/streams/StreamUtils.h

Loading...
View Options

testing/web-platform/tests/encoding/streams/stringification-crash.html

Loading...
Privacy · Cookies · Legal