LLVM Bugzilla is read-only and represents the historical archive of all LLVM issues filled before November 26, 2021. Use github to submit LLVM bugs

Bug 48007 - Backport 0f60bcc36c34522618bd1425a45f8c6006568fb6 to 11.0.1
Summary: Backport 0f60bcc36c34522618bd1425a45f8c6006568fb6 to 11.0.1
Status: RESOLVED FIXED
Alias: None
Product: libraries
Classification: Unclassified
Component: Backend: X86 (show other bugs)
Version: trunk
Hardware: PC Windows NT
: P enhancement
Assignee: Craig Topper
URL:
Keywords:
Depends on:
Blocks: release-11.0.1
  Show dependency tree
 
Reported: 2020-10-29 01:59 PDT by sguelton
Modified: 2020-11-24 19:02 PST (History)
7 users (show)

See Also:
Fixed By Commit(s): 0f60bcc36c34522618bd1425a45f8c6006568fb6 f2c6bfa350de142e4d63808d03335f69bd136d6a 9573c9f2a363da71b2c07a3add4e52721e6028a0 bbe6cbbed8c aac36687f79 a1e0363c740


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description sguelton 2020-10-29 01:59:03 PDT
It contains stack clash fixes.
Comment 1 Tom Stellard 2020-11-02 20:57:25 PST
Hi Craig,

What is your opinion on backporting this?

https://reviews.llvm.org/rG8a74dfb30a372a6e2c55c1e0cc93cd235b9de695
Comment 2 Tom Stellard 2020-11-02 20:58:16 PST
(In reply to Tom Stellard from comment #1)
> Hi Craig,
> 
> What is your opinion on backporting this?
> 
> https://reviews.llvm.org/rG8a74dfb30a372a6e2c55c1e0cc93cd235b9de695

Serge, this commit does not exist, did you get the hash right?
Comment 3 sguelton 2020-11-02 22:44:53 PST
My bad, it was https://reviews.llvm.org/rG0f60bcc36c34522618bd1425a45f8c6006568fb6
Comment 4 Tom Stellard 2020-11-02 22:46:00 PST
Hi Craig,

What is your opinion on backporting this?

https://reviews.llvm.org/rG0f60bcc36c34522618bd1425a45f8c6006568fb6
Comment 5 Craig Topper 2020-11-02 23:13:52 PST
I think its ok to backport.
Comment 6 sguelton 2020-11-05 05:15:43 PST
For the record, this commit depends on
f2c6bfa350de142e4d63808d03335f69bd136d6a
and
9573c9f2a363da71b2c07a3add4e52721e6028a0

I've applied the three commits here:

https://github.com/serge-sans-paille/llvm-project/commit/e736a9840c3e483c157b79875ea6396157acc50e
https://github.com/serge-sans-paille/llvm-project/commit/e48a95541c080463f93c41d9801f3ae62110d56b
https://github.com/serge-sans-paille/llvm-project/commit/575fc4bd0c5211fa624db124166cacfe1a2c7d93
Comment 7 Tom Stellard 2020-11-23 16:19:24 PST
Craig, what do you think about all 3 of these patches:

https://github.com/tstellar/llvm-project/pull/237/files
Comment 8 Craig Topper 2020-11-24 16:16:48 PST
I think its ok to merge.
Comment 9 Tom Stellard 2020-11-24 19:02:17 PST
Merged: a1e0363c740