LLVM Bugzilla is read-only and represents the historical archive of all LLVM issues filled before November 26, 2021. Use github to submit LLVM bugs

Bug 46360 - Merge 252892fea7088abbeff9476e0ecbacc091d135a0 into the 10.0 branch
Summary: Merge 252892fea7088abbeff9476e0ecbacc091d135a0 into the 10.0 branch
Status: RESOLVED FIXED
Alias: None
Product: new-bugs
Classification: Unclassified
Component: new bugs (show other bugs)
Version: 10.0
Hardware: All All
: P enhancement
Assignee: Mehdi Amini
URL:
Keywords:
Depends on:
Blocks: release-10.0.1
  Show dependency tree
 
Reported: 2020-06-16 21:19 PDT by Yuanfang Chen
Modified: 2020-06-23 14:18 PDT (History)
4 users (show)

See Also:
Fixed By Commit(s): 252892fea7088abbeff9476e0ecbacc091d135a0 8f299fd2cff

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yuanfang Chen 2020-06-16 21:19:12 PDT 
Is it OK to merge the following revision(s) to the 10.0 branch?
Comment 2 Yuanfang Chen 2020-06-16 21:25:56 PDT 
This helps ThinLTO caching a lot.

```
commit 252892fea7088abbeff9476e0ecbacc091d135a0
Author:     romanova-ekaterina <katya.romanova@sony.com>
AuthorDate: Tue Jun 9 13:46:28 2020 -0700
Commit:     romanova-ekaterina <katya.romanova@sony.com>
CommitDate: Wed Jun 10 12:41:41 2020 -0700

    Fixed false ThinLTO cache misses problem (PR 45819).

    We relied on the fact that the iterators walks through the elements of a
    DenseSet in a deterministic order (which is not true). This caused
    ThinLTO cache misses. This patch addresses this problem.
    See PR 45819 for additional information
    https://bugs.llvm.org/show_bug.cgi?id=45819

    Differential Revision: https://reviews.llvm.org/D79772
```
Comment 3 Tom Stellard 2020-06-17 17:56:12 PDT 
Mehdi, what is your opinion about backporting this?

https://reviews.llvm.org/rG252892fea7088abbeff9476e0ecbacc091d135a0
Comment 4 Mehdi Amini 2020-06-17 19:12:29 PDT 
Seems like low-risk: the cache is invalidate on a new version of the compiler anyway.

Adding Teresa to get a second opinion?
Comment 5 Teresa Johnson 2020-06-18 13:00:49 PDT 
I agree, think it would be good and low risk to merge.
Comment 6 Tom Stellard 2020-06-23 14:18:29 PDT 
Merged: 8f299fd2cff