fix: SMB version detection (issue #2744) #2745
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Since nmap version 7.93 the versions of SMB servers are returned in wrong format. - This commit fixes the root cause by changing `tohex` function. - `stdnse.tohex` is called from smb2 scripts to generate the name of the version. - See GH issue nmap#2744 for further details.
nnposter
reviewed
Aug 5, 2024
nnposter
left a comment
There was a problem hiding this comment.
This code is problematic on several counts:
- Per documentation, the separator is an arbitrary string, not a single character. The code would have to be significantly redesigned to make it work as expected.
- The code does not account for the possibility that the separator might be a character with special meaning when used inside Lua patterns.
- The replacement value is unnecessarily recalculated with every substitution. This should be moved out of the loop, just like
patalready is, to avoid performance penalty.
See #2901 for a more comprehensive fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tohexfunction.stdnse.tohexis called from smb2 scripts to generate the name of the version.