changeset:   70347:bd17396895fb
branch:      3.1
parent:      70343:3e1709213532
user:        Victor Stinner <victor.stinner@haypocalc.com>
date:        Tue May 24 22:17:55 2011 +0200
files:       Lib/test/test_multibytecodec.py Misc/NEWS Modules/cjkcodecs/multibytecodec.c
description:
Issue #12100: Don't reset incremental encoders of CJK codecs at each call to
their encode() method anymore, but continue to call the reset() method if the
final argument is True.


diff -r 3e1709213532 -r bd17396895fb Lib/test/test_multibytecodec.py
--- a/Lib/test/test_multibytecodec.py	Tue May 24 12:50:34 2011 -0500
+++ b/Lib/test/test_multibytecodec.py	Tue May 24 22:17:55 2011 +0200
@@ -257,6 +257,36 @@
             # Any ISO 2022 codec will cause the segfault
             myunichr(x).encode('iso_2022_jp', 'ignore')
 
+class TestStateful(unittest.TestCase):
+    text = '\u4E16\u4E16'
+    encoding = 'iso-2022-jp'
+    expected = b'\x1b$B@$@$'
+    expected_reset = b'\x1b$B@$@$\x1b(B'
+
+    def test_encode(self):
+        self.assertEqual(self.text.encode(self.encoding), self.expected_reset)
+
+    def test_incrementalencoder(self):
+        encoder = codecs.getincrementalencoder(self.encoding)()
+        output = b''.join(
+            encoder.encode(char)
+            for char in self.text)
+        self.assertEqual(output, self.expected)
+
+    def test_incrementalencoder_final(self):
+        encoder = codecs.getincrementalencoder(self.encoding)()
+        last_index = len(self.text) - 1
+        output = b''.join(
+            encoder.encode(char, index == last_index)
+            for index, char in enumerate(self.text))
+        self.assertEqual(output, self.expected_reset)
+
+class TestHZStateful(TestStateful):
+    text = '\u804a\u804a'
+    encoding = 'hz'
+    expected = b'~{ADAD'
+    expected_reset = b'~{ADAD~}'
+
 def test_main():
     support.run_unittest(__name__)
 
diff -r 3e1709213532 -r bd17396895fb Misc/NEWS
--- a/Misc/NEWS	Tue May 24 12:50:34 2011 -0500
+++ b/Misc/NEWS	Tue May 24 22:17:55 2011 +0200
@@ -75,6 +75,10 @@
 Library
 -------
 
+- Issue #12100: Don't reset incremental encoders of CJK codecs at each call to
+  their encode() method anymore, but continue to call the reset() method if the
+  final argument is True.
+
 - Issue #5715: In socketserver, close the server socket in the child process.
 
 - Issue #12124: zipimport doesn't keep a reference to zlib.decompress() anymore
diff -r 3e1709213532 -r bd17396895fb Modules/cjkcodecs/multibytecodec.c
--- a/Modules/cjkcodecs/multibytecodec.c	Tue May 24 12:50:34 2011 -0500
+++ b/Modules/cjkcodecs/multibytecodec.c	Tue May 24 22:17:55 2011 +0200
@@ -479,7 +479,7 @@
     MultibyteEncodeBuffer buf;
     Py_ssize_t finalsize, r = 0;
 
-    if (datalen == 0)
+    if (datalen == 0 && !(flags & MBENC_RESET))
         return PyBytes_FromStringAndSize(NULL, 0);
 
     buf.excobj = NULL;
@@ -514,7 +514,7 @@
             break;
     }
 
-    if (codec->encreset != NULL)
+    if (codec->encreset != NULL && (flags & MBENC_RESET))
         for (;;) {
             Py_ssize_t outleft;
 
@@ -784,8 +784,8 @@
     inbuf_end = inbuf + datalen;
 
     r = multibytecodec_encode(ctx->codec, &ctx->state,
-                    (const Py_UNICODE **)&inbuf,
-                    datalen, ctx->errors, final ? MBENC_FLUSH : 0);
+                    (const Py_UNICODE **)&inbuf, datalen,
+                    ctx->errors, final ? MBENC_FLUSH | MBENC_RESET : 0);
     if (r == NULL) {
         /* recover the original pending buffer */
         if (origpending > 0)