changeset: 101439:90e58a77d386 branch: 3.4 parent: 101211:5cf064bf81fd user: Guido van Rossum date: Thu May 19 13:00:21 2016 -0700 files: Doc/library/pathlib.rst Lib/pathlib.py Lib/test/test_pathlib.py Misc/NEWS description: Back out 7e9605697dfc, 2e3c31ab586a, 759b2cecc289. These added a path attribute to pathlib.Path objects, and docs. Instead, we're going to use PEP 519. (Starting in the 3.4 branch and merging forward from there since that's what I did originally.) diff -r 5cf064bf81fd -r 90e58a77d386 Doc/library/pathlib.rst --- a/Doc/library/pathlib.rst Mon May 02 07:03:46 2016 -0400 +++ b/Doc/library/pathlib.rst Thu May 19 13:00:21 2016 -0700 @@ -365,24 +365,6 @@ '' -.. data:: PurePath.path - - A string representing the full path:: - - >>> PurePosixPath('my/library/setup.py').path - 'my/library/setup.py' - - This always returns the same value as ``str(p)``; it is included to - serve as a one-off protocol. Code that wants to support both - strings and ``pathlib.Path`` objects as filenames can write - ``arg = getattr(arg, 'path', arg)`` to get the path as a string. - This can then be passed to various system calls or library - functions that expect a string. Unlike the alternative - ``arg = str(arg)``, this will still raise an exception if an object - of some other type is given by accident. - - .. versionadded:: 3.4.5 - .. data:: PurePath.suffix The file extension of the final component, if any:: diff -r 5cf064bf81fd -r 90e58a77d386 Lib/pathlib.py --- a/Lib/pathlib.py Mon May 02 07:03:46 2016 -0400 +++ b/Lib/pathlib.py Thu May 19 13:00:21 2016 -0700 @@ -648,13 +648,6 @@ self._parts) or '.' return self._str - @property - def path(self): - try: - return self._str - except AttributeError: - return str(self) - def as_posix(self): """Return the string representation of the path with forward (/) slashes.""" diff -r 5cf064bf81fd -r 90e58a77d386 Lib/test/test_pathlib.py --- a/Lib/test/test_pathlib.py Mon May 02 07:03:46 2016 -0400 +++ b/Lib/test/test_pathlib.py Thu May 19 13:00:21 2016 -0700 @@ -480,22 +480,6 @@ self.assertEqual(P('a/b.py').name, 'b.py') self.assertEqual(P('/a/b.py').name, 'b.py') - def test_path_common(self): - P = self.cls - def check(arg, expected=None): - if expected is None: - expected = arg - self.assertEqual(P(arg).path, expected.replace('/', self.sep)) - check('', '.') - check('.') - check('/') - check('a/b') - check('/a/b') - check('/a/b/', '/a/b') - check('/a/b/.', '/a/b') - check('a/b.py') - check('/a/b.py') - def test_suffix_common(self): P = self.cls self.assertEqual(P('').suffix, '') @@ -919,17 +903,6 @@ self.assertEqual(P('//My.py/Share.php').name, '') self.assertEqual(P('//My.py/Share.php/a/b').name, 'b') - def test_path(self): - P = self.cls - self.assertEqual(P('c:').path, 'c:') - self.assertEqual(P('c:/').path, 'c:\\') - self.assertEqual(P('c:a/b').path, 'c:a\\b') - self.assertEqual(P('c:/a/b').path, 'c:\\a\\b') - self.assertEqual(P('c:a/b.py').path, 'c:a\\b.py') - self.assertEqual(P('c:/a/b.py').path, 'c:\\a\\b.py') - self.assertEqual(P('//My.py/Share.php').path, '\\\\My.py\\Share.php\\') - self.assertEqual(P('//My.py/Share.php/a/b').path, '\\\\My.py\\Share.php\\a\\b') - def test_suffix(self): P = self.cls self.assertEqual(P('c:').suffix, '') diff -r 5cf064bf81fd -r 90e58a77d386 Misc/NEWS --- a/Misc/NEWS Mon May 02 07:03:46 2016 -0400 +++ b/Misc/NEWS Thu May 19 13:00:21 2016 -0700 @@ -21,12 +21,6 @@ - Issue #25939: On Windows open the cert store readonly in ssl.enum_certificates. -- Issue #22570: Add 'path' attribute to pathlib.Path objects, - returning the same as str(), to make it more similar to DirEntry. - Library code can now write getattr(p, 'path', p) to get the path as - a string from a Path, a DirEntry, or a plain string. This is - essentially a small one-off protocol. - - Issue #26012: Don't traverse into symlinks for ** pattern in pathlib.Path.[r]glob().