changeset: 74642:856f0864437a user: Victor Stinner date: Fri Jan 27 01:03:25 2012 +0100 files: Lib/test/test_time.py description: Issue #13847: Make test_localtime_failure() more robust Skip the test if we are unable to find an invalid time_t value. diff -r 516d42a6e518 -r 856f0864437a Lib/test/test_time.py --- a/Lib/test/test_time.py Fri Jan 27 00:50:33 2012 +0100 +++ b/Lib/test/test_time.py Fri Jan 27 01:03:25 2012 +0100 @@ -345,16 +345,21 @@ def test_localtime_failure(self): # Issue #13847: check for localtime() failure - invalid_time_t = 2**60 - try: - time.localtime(invalid_time_t) - except ValueError as err: - if str(err) == "timestamp out of range for platform time_t": - self.skipTest("need 64-bit time_t") - else: - raise - except OSError: - pass + invalid_time_t = None + for time_t in (-1, 2**30, 2**33, 2**60): + try: + time.localtime(time_t) + except ValueError as err: + if str(err) == "timestamp out of range for platform time_t": + self.skipTest("need 64-bit time_t") + else: + raise + except OSError: + invalid_time_t = time_t + break + if invalid_time_t is None: + self.skipTest("unable to find an invalid time_t value") + self.assertRaises(OSError, time.localtime, invalid_time_t) self.assertRaises(OSError, time.gmtime, invalid_time_t) self.assertRaises(OSError, time.ctime, invalid_time_t)