changeset: 105691:5ec5bfcf0089 user: Raymond Hettinger date: Fri Dec 16 14:59:37 2016 -0800 files: Lib/functools.py description: Issue #28991: Address comment that the __len__ call looked unattractive diff -r c6346144a9bb -r 5ec5bfcf0089 Lib/functools.py --- a/Lib/functools.py Fri Dec 16 13:59:57 2016 -0800 +++ b/Lib/functools.py Fri Dec 16 14:59:37 2016 -0800 @@ -493,6 +493,7 @@ hits = misses = 0 full = False cache_get = cache.get # bound method to lookup a key or return None + cache_len = cache.__len__ # get cache size without calling len() lock = RLock() # because linkedlist updates aren't threadsafe root = [] # root of the circular doubly linked list root[:] = [root, root, None, None] # initialize by pointing to self @@ -574,16 +575,16 @@ last = root[PREV] link = [last, root, key, result] last[NEXT] = root[PREV] = cache[key] = link - # Use the __len__() method instead of the len() function + # Use the cache_len bound method instead of the len() function # which could potentially be wrapped in an lru_cache itself. - full = (cache.__len__() >= maxsize) + full = (cache_len() >= maxsize) misses += 1 return result def cache_info(): """Report cache statistics""" with lock: - return _CacheInfo(hits, misses, maxsize, cache.__len__()) + return _CacheInfo(hits, misses, maxsize, cache_len()) def cache_clear(): """Clear the cache and cache statistics"""