-
Notifications
You must be signed in to change notification settings - Fork 18.8k
Description
Noticed indirectly via #53933: when packages are outside of the workspace, autocompletion stops working because it operates on packages in "TypeCheckWorkspace" mode, which means it does have function bodies for packages outside of the workspace.
That's not wrong, but we should automatically include any open packages in the workspace.
For the most part it should "just work" to adjust our workspace package algorithm, we just need to be sure to recompute workspace packages (snapshot.computeWorkspacePackages) following any didOpen or didClose event.
This is low-hanging fruit, as particularly with #53880 it could significantly improve the user experience with go.work files when opening a package outside the workspace: some functionality will still work, and the user will be alerted that other functionality will be degraded.