duplicate-tab icon indicating copy to clipboard operation
duplicate-tab copied to clipboard

Pop tab out to incognito window

Open stefansundin opened this issue 2 years ago • 4 comments

Hi @stefansundin, thanks for the awesome tool! I have a quick incognito-related follow-up.

Is there a "Pop tab out to a new INCOGNITO window shortcut"? E.g., the current tab is in non-incognito mode, and I want to duplicate that tab in a new INCOGNITO window.

I understand that the original issue in this thread is closed, so if you want me to open a new issue for this, let me know. Thanks!

Originally posted by @thadikari in https://github.com/stefansundin/duplicate-tab/issues/17#issuecomment-1781832997

stefansundin avatar Nov 01 '23 09:11 stefansundin

Hello @thadikari. I believe this should be possible, so I made a new issue for it. I am not sure I will include it in the official version, but at least we can experiment here, and if it does work well enough then I'll probably include it in a new version.

The windows.create() API allows an incognito flag, which should make this possible. https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/API/windows/create#incognito

It might take a while before I have time to test this though, but at least we have an issue for it now and hopefully I won't forget about it.

stefansundin avatar Nov 01 '23 09:11 stefansundin

Awesome! Thank you!

thadikari avatar Nov 01 '23 14:11 thadikari

@thadikari Sorry for the delay but I just wrote this feature for you and it works great. Hope you are still interested in trying it out. The code changes requires are located in a pull request, along with the instructions on how to try it out: https://github.com/stefansundin/duplicate-tab/pull/23

As is explained in the PR, I don't think I will merge it and release it. So for now you have to download and load it manually.

I forgot to ask before, but do you use Chrome or Firefox? The feature works in both but I am still curious.

Enjoy!

stefansundin avatar Dec 23 '23 06:12 stefansundin

@stefansundin Huge thanks for implementing this feature! I use Chrome. Just tried this out and it works great!

I understand your reservations about releasing this feature.

Nevertheless, thank you again for taking time to implement this. Happy holidays!

thadikari avatar Dec 25 '23 13:12 thadikari