SonataMediaBundle icon indicating copy to clipboard operation
SonataMediaBundle copied to clipboard

Liip imagine integration and svg

Open dima-gr opened this issue 4 years ago • 6 comments

If you enable integration with liip imagine, svg image downloaded and render in admin list but when you try render image somewhere in twig template then svg not rendered, maybe you don't need to apply the filter for them

dima-gr avatar Nov 29 '21 08:11 dima-gr

Can you provide a PR with this feature @dima-gr ?

core23 avatar Nov 29 '21 09:11 core23

Ok, but it will be littlebit later

dima-gr avatar Nov 29 '21 09:11 dima-gr

Friendly ping @dima-gr, do you have some time for this feature ?

VincentLanglet avatar Mar 31 '22 20:03 VincentLanglet

I'll try provide a PR in the next week

dima-gr avatar Mar 31 '22 21:03 dima-gr

I'm create PR, the problem is that the GD driver does not support working with svg, the entry is marked as MediaInterface::STATUS_ERROR, it happens in ImageProvider.php on 283 line

        try {
            $image = $this->imagineAdapter->open($binaryContent->getPathname());
        } catch (\RuntimeException $e) {
            $media->setProviderStatus(MediaInterface::STATUS_ERROR);

            return;
        }

dima-gr avatar Apr 06 '22 09:04 dima-gr

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar Oct 03 '22 10:10 github-actions[bot]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar Apr 08 '23 14:04 github-actions[bot]