scrapyd icon indicating copy to clipboard operation
scrapyd copied to clipboard

Add 'Schedule' buttons in the Jobs page

Open my8100 opened this issue 7 years ago • 6 comments

This PR adds a schedule endpoint based on #256. Note that the 'Cancel' and the 'Schedule' buttons still not visible in Python 3 due to #312.

my8100 avatar Apr 20 '19 14:04 my8100

Codecov Report

Merging #321 into master will decrease coverage by 0.45%. The diff coverage is 11.11%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #321      +/-   ##
==========================================
- Coverage   68.37%   67.91%   -0.46%     
==========================================
  Files          16       16              
  Lines         819      826       +7     
  Branches       96       98       +2     
==========================================
+ Hits          560      561       +1     
- Misses        230      236       +6     
  Partials       29       29
Impacted Files Coverage Δ
scrapyd/website.py 56.43% <11.11%> (-3.14%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5298f9b...c0a9b06. Read the comment docs.

codecov[bot] avatar Apr 20 '19 14:04 codecov[bot]

Codecov Report

Merging #321 into master will decrease coverage by 0.45%. The diff coverage is 11.11%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #321      +/-   ##
==========================================
- Coverage   68.37%   67.91%   -0.46%     
==========================================
  Files          16       16              
  Lines         819      826       +7     
  Branches       96       98       +2     
==========================================
+ Hits          560      561       +1     
- Misses        230      236       +6     
  Partials       29       29
Impacted Files Coverage Δ
scrapyd/website.py 56.43% <11.11%> (-3.14%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5298f9b...c0a9b06. Read the comment docs.

codecov[bot] avatar Apr 20 '19 14:04 codecov[bot]

@Digenis, What do you think about the added 'Schedule' button?

my8100 avatar Apr 21 '19 12:04 my8100

There's no way to add arguments and settings and, taken from the finished jobs, it creates the confusion that the job will run with the same arguments.

The reason I wrote the cancel shortcut is that the solution suits any user.

If we add a form to add arguments, we are getting in to the scope of other tools such as scrapyweb. What do you think?

Digenis avatar Apr 22 '19 15:04 Digenis

Not every spider run needs arguments and settings from cmd. And it's convenient for repeating crawling jobs with just a click.

PS: typo for scrapydweb

my8100 avatar Apr 22 '19 15:04 my8100

I share the concerns of @Digenis in https://github.com/scrapy/scrapyd/pull/321#issuecomment-485448325

jpmckinney avatar Sep 24 '21 00:09 jpmckinney