3dfx Voodoo shows the wrong aspect ratio
So happy to finally see Voodoo support! :D Excellent work! The best DOS emulator just got even better.
I've tried these 4 games so far: Carmageddon, Screamer 2, Screamer Rally, and Fatal Racing/Whiplash.
When running with 3dfx all of these games do not display in the 4:3 aspect ratio when 'Aspect Ratio Correction' is set to 'On'. They all take up 100% of the screen (16:9 in my case). To get them to display in 4:3 i have to set 'Aspect Ratio Correction' to 'Off'. This happens on Windows 10 with a clean RA install, and i've also tried using other drivers like Vulkan and D3D12 which make no difference.
With Fatal Racing/Whiplash it gets weirder, as the game starts up in 4:3 when 'Aspect Ratio Correction' is Off, but when on the main menu screen and during gameplay it will then be displayed in what is roughly a 16:10 aspect ratio:

But if i then set 'Aspect Ratio Correction' to 'On' will correctly show the menu screen and the gameplay in 4:3, but when the game starts up it will now be in widescreen looking like this:

So there's no way to always have this game displayed in 4:3 with a single setting when using 3dfx. But aspect ratio correction works fine with this game and all other games when not using 3dfx.
Anyway i'm currently doing more testing and will report anything else if i find anything :)
Ah, interesting. The way the Voodoo emulation takes over the drawing to the emulated display I can see this being a bit weird with the aspect ratio option.
I have not at all tested this so thanks for this report. How do you think the "aspect ratio correction" should work in regards to 3dfx? All I can think of is making it either do nothing at all. Having it apply just some fixed ratio would probably be weird, and if someone would want that, RetroArch can do that already.
Looks like RA's own Video > Scaling > Aspect Ratio setting works well with all the 3dfx games i've tried so far... But the major downside to this method is that it will apply 4:3 to literally all cores/games. It can't be individually adjusted (as far as i'm aware).
So unless you can think of a better way i'd rather DBP had Its own 4:3 fixed aspect ratio option. So you could keep the current 4:3 option but also add 'Fixed 4:3'. This way each game can be customised within the core Options. It's much better than having RA apply the same aspect ratio to everything.
Looks like RA's own Video > Scaling > Aspect Ratio setting works well with all the 3dfx games i've tried so far... But the major downside to this method is that it will apply 4:3 to literally all cores/games. It can't be individually adjusted (as far as i'm aware).
So unless you can think of a better way i'd rather DBP had Its own 4:3 fixed aspect ratio option. So you could keep the current 4:3 option but also add 'Fixed 4:3'. This way each game can be customised within the core Options. It's much better than having RA apply the same aspect ratio to everything.
Any RA setting should be able to override at a per-game and per-core level using “override” function in Quick Menu. Or you can manually create these override config by hand in config folders.
Is this better now in the latest version?
Yep! Every game is now showing the correct 4:3 aspect ratio :)
I spoke too soon... There's one game that still shows the wrong aspect ratio, but it's a minor issue because it's just the opening demo/intro. Fatal Racing/Whiplash shows a vertically compressed image with a black border at the bottom when you start the game:

It's the same when using both 'On' or 'Off' Aspect Ratio Correction settings. Looks like this game might be doing something weird. But the menu screens and gameplay are correctly displayed in 4:3.