fast-excel icon indicating copy to clipboard operation
fast-excel copied to clipboard

fix download

Open binkztep opened this issue 6 years ago • 4 comments

fixed bug, when we received corrupted (non-opening) file with download() method

binkztep avatar Sep 24 '19 16:09 binkztep

Hi, thank you for your contribution! The exportOrDownload function can download or export. It means the file can be saved and in this case, the program should not stop. Still, https://github.com/box/spout/issues/168#issuecomment-197276897 issue says "This is not a library issue". So I guess users have to add exit by theirselves.

rap2hpoutre avatar Sep 30 '19 05:09 rap2hpoutre

Hi, @rap2hpoutre ! Yes, its said "This is not a library issue", but no Spout issue. In that part of code you are using Spout and we need to add this 'exit;' line to get proper (not corrupted) file on download method. Export functionality is not hurted with this.

binkztep avatar Sep 30 '19 13:09 binkztep

Hi, without this fix method download don't work, using laravel 5.5

goten60 avatar Jun 21 '20 01:06 goten60

In order to solve the issue correctly you should use Laravel means for the file download organization. See https://laravel.com/docs/8.x/responses#file-downloads

klimov-paul avatar Feb 08 '22 16:02 klimov-paul

Issue is resolved now

rap2hpoutre avatar Sep 01 '23 06:09 rap2hpoutre