pybuilder icon indicating copy to clipboard operation
pybuilder copied to clipboard

Added: Possibility to specify extension modules.

Open margru opened this issue 6 years ago • 10 comments

This is an improvement to fix #639. The extensions might be defined in project's distutils_ext_modules property as a list of dictionaries where each dictionary represents keyword arguments with values for a single Extension instance constructor. Multiple dictionaries mean multiple extensions to build. The extensions specifications are then rendered into the setup.py script via the template.

margru avatar Aug 08 '19 09:08 margru

@margru thank you for you pull-request, we do appreciate it. Unfortunately, we don't have any resources at the moment to service it so please be patient.

esc avatar Aug 08 '19 11:08 esc

Thanks for the PR! I'm working on a major fix for the PyB with environment isolation and will look at this ASAP afterwards.

arcivanov avatar Aug 28 '19 17:08 arcivanov

this makes no sense ;)

What doesn't make sense? Can you please be more specific?

Edit: Sorry, I didn't notice that you are commenting just a specific line in the code. See my comment there...

margru avatar Nov 04 '19 09:11 margru

Coverage Status

Coverage decreased (-0.5%) to 74.267% when pulling 8dde5e6a6beccc5c682e6b3577c668b0b76130a8 on margru:master into 9a98c2de8dcf5cba53d1833f20a24e23d08bcf84 on pybuilder:master.

coveralls avatar Nov 04 '19 09:11 coveralls

Could you please rebase on current?

arcivanov avatar Aug 03 '22 14:08 arcivanov

@margru ?

arcivanov avatar Aug 05 '22 23:08 arcivanov

@arcivanov Yeah, I will try but I don't have that much time right now to solve the conflicts. I didn't realize that the push will also update the PR...

margru avatar Aug 08 '22 05:08 margru