PMM-10095 Automatic service lookup during removal
PMM-10095
Build: SUBMODULES-0
- [ ] Links to other linked pull requests (optional).
I would recommend keeping this logic on the pmm-admin side and changing the logic this way:
- pmm-admin sends a request to pmm-managed to get services related to the current node
- if we have only one service in the response remove that node
here you can see how to get services for the current node
we can extract duplicated code to one place
Yep. That makes sense. Thanks
@gen1us2k looks good, just small comments
Yes. Sure
Codecov Report
Merging #998 (a961897) into main (5a64417) will increase coverage by
0.80%. The diff coverage is0.00%.
@@ Coverage Diff @@
## main #998 +/- ##
==========================================
+ Coverage 45.17% 45.97% +0.80%
==========================================
Files 140 323 +183
Lines 13586 39858 +26272
==========================================
+ Hits 6137 18324 +12187
- Misses 7056 19978 +12922
- Partials 393 1556 +1163
| Flag | Coverage Δ | |
|---|---|---|
| admin | 24.30% <0.00%> (-0.22%) |
:arrow_down: |
| agent | 53.89% <ø> (+0.16%) |
:arrow_up: |
| managed | 46.39% <ø> (?) |
Flags with carried forward coverage won't be shown. Click here to find out more.
| Impacted Files | Coverage Δ | |
|---|---|---|
| admin/commands/management/remove.go | 9.37% <0.00%> (-12.06%) |
:arrow_down: |
| managed/models/service_model_reform.go | 95.83% <0.00%> (ø) |
|
| ...anaged/services/management/grpc/proxysql_server.go | 0.00% <0.00%> (ø) |
|
| managed/utils/tests/credentials.go | 71.42% <0.00%> (ø) |
|
| managed/services/management/grpc/mongodb_server.go | 0.00% <0.00%> (ø) |
|
| managed/services/supervisord/pmm_update_checker.go | 80.68% <0.00%> (ø) |
|
| ...ervices/management/dbaas/version_service_client.go | 62.20% <0.00%> (ø) |
|
| managed/models/artifact_helpers.go | 58.33% <0.00%> (ø) |
|
| .../services/telemetry/datasource_victoria_metrics.go | 0.00% <0.00%> (ø) |
|
| ...ged/services/management/dbaas/kubernetes_server.go | 50.67% <0.00%> (ø) |
|
| ... and 176 more |
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more