hydra icon indicating copy to clipboard operation
hydra copied to clipboard

docs: add license headers to all files

Open kevgo opened this issue 3 years ago • 3 comments

Add a license header to all source code files.

Related issue(s)

https://github.com/ory-corp/general/issues/602

Checklist

  • [x] I have read the contributing guidelines.
  • [x] I have referenced an issue containing the design document if my change introduces a new feature.
  • [x] I am following the contributing code guidelines.
  • [x] I have read the security policy.
  • [x] I confirm that this pull request does not address a security vulnerability. If this pull request addresses a security. vulnerability, I confirm that I got green light (please contact [email protected]) from the maintainers to push the changes.
  • [ ] I have added tests that prove my fix is effective or that my feature works.
  • [ ] I have added or changed the documentation.

Further Comments

This is just a demo of the capability for now. Please provide feedback to fine-tune the generated headers.

kevgo avatar Aug 03 '22 19:08 kevgo

Codecov Report

Merging #3216 (7560617) into master (f8a7ced) will increase coverage by 0.00%. The diff coverage is 0.00%.

:exclamation: Current head 7560617 differs from pull request most recent head b65083c. Consider uploading reports for the commit b65083c to get more accurate results

@@           Coverage Diff           @@
##           master    #3216   +/-   ##
=======================================
  Coverage   76.86%   76.86%           
=======================================
  Files         123      123           
  Lines        8920     8922    +2     
=======================================
+ Hits         6856     6858    +2     
- Misses       1636     1637    +1     
+ Partials      428      427    -1     
Impacted Files Coverage Δ
client/client.go 75.75% <ø> (ø)
client/handler.go 78.44% <ø> (ø)
client/manager_test_helpers.go 98.51% <ø> (ø)
client/validator.go 72.64% <ø> (ø)
cmd/cli/error.go 0.00% <ø> (ø)
cmd/cli/handler.go 100.00% <ø> (ø)
cmd/cli/handler_helper.go 57.89% <ø> (ø)
cmd/cli/handler_janitor.go 80.85% <ø> (ø)
cmd/cli/handler_jwk.go 100.00% <ø> (ø)
cmd/cli/handler_migrate.go 1.04% <ø> (ø)
... and 115 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov[bot] avatar Aug 03 '22 20:08 codecov[bot]

Could you exclude autogenerated files in internal/httpclient please? :)

aeneasr avatar Sep 10 '22 07:09 aeneasr

Great feedback to exclude auto-generated files! https://github.com/ory/cli/pull/214 adds the missing feature. The changes in this PR are a preview of how this would look like. They were created by running:

ory dev headers license --exclude=internal/httpclient

kevgo avatar Sep 13 '22 20:09 kevgo

Blocking on shipping https://github.com/ory/cli/pull/239 as a new Ory CLI version.

kevgo avatar Oct 07 '22 23:10 kevgo