DownOnSpot icon indicating copy to clipboard operation
DownOnSpot copied to clipboard

Allow Building without mp3 support

Open DavidBuchanan314 opened this issue 3 years ago • 4 comments

Is your feature request related to a problem? Please describe. Installing the libmp3lame dependency on macOS looks annoying, and I don't plan on using the mp3 feature anyway, so it'd be nice to not include it in the build process.

Describe the solution you'd like An option to build without mp3 conversion support, excluding mp3lame

DavidBuchanan314 avatar May 19 '22 13:05 DavidBuchanan314

Yeah brew install lame doesn't seem to actually install the library on mac and there's not a ton of info online.

grantHarris avatar Jun 23 '22 20:06 grantHarris

btw, I was able to compile it in the end by just deleting all the mp3-related code. But I was in a rush so I didn't try to implement it as an actual feature

DavidBuchanan314 avatar Jun 23 '22 23:06 DavidBuchanan314

I ended up just building it in a docker container and bypassed running it directly on the Mac OS. That said, I'd support a build that doesn't require that dependancy (I'm using it with Traktor which can read ogg so I'd rather not reencode anyways)

grantHarris avatar Jun 28 '22 05:06 grantHarris

The library is only required for linking. Include the path here.

oSumAtrIX avatar Jun 28 '22 08:06 oSumAtrIX

export LIBRARY_PATH="/usr/local/lib"
ln /opt/homebrew/opt/lame/lib/libmp3lame.dylib "$LIBRARY_PATH/libmp3lame.dylib"

mossepso avatar Nov 28 '22 21:11 mossepso