SDL icon indicating copy to clipboard operation
SDL copied to clipboard

x11: Remove text-scaling-factor setting checks

Open ebassi opened this issue 1 year ago • 1 comments

The text-scaling-factor setting is not useful, now that we watch the Xft/DPI and Gdk/WindowScalingFactor XSETTINGS keys; on the contrary, it is problematic in mixed environments with both the KDE and GNOME portals, as they end up stepping on each other's toes, and we end up with the wrong scaling factor value.

Fixes: https://github.com/libsdl-org/SDL/issues/11142

ebassi avatar Oct 17 '24 16:10 ebassi

This MR removes a bunch of code, so additional testing is appreciated.

ebassi avatar Oct 17 '24 16:10 ebassi

Copying my comment here, as I accidentally commented in the issue instead.

This works correctly for me in KDE+Xwayalnd and KDE+X11.

@ebassi Can you let know if this worked okay for you in both session types in gnome? If so, I think this should be good to merge.

lostgoat avatar Oct 21 '24 19:10 lostgoat

Merged, thanks!

slouken avatar Oct 21 '24 22:10 slouken