website icon indicating copy to clipboard operation
website copied to clipboard

[Bug] Unclear format for renewBefore arument to be set for certificate expiry

Open fast-n-curious opened this issue 1 year ago • 6 comments

Kyverno Version

1.12.6

Description

Currently the default value and the description for configuring the argument makes the user think the format to be set in days like: - --renewBefore=1d

But, the value needs to be set in hours/mins etc. which is displayed in the logs if a wrong value is set.

  -renewBefore duration
    	The certificate renewal time before expiration (default 360h0m0s)

Also specify any minimum value if there’s a limit to which the minimum duration for the certificate renewal applies.

Argument description is set here: https://kyverno.io/docs/installation/customization/#container-flags

Slack discussion

No response

Troubleshooting

  • [x] I have read and followed the documentation AND the troubleshooting guide.
  • [x] I have searched other issues in this repository and mine is not recorded.

fast-n-curious avatar Mar 13 '25 20:03 fast-n-curious

Thanks for opening your first issue here! Be sure to follow the issue template!

welcome[bot] avatar Mar 13 '25 20:03 welcome[bot]

Thanks for opening your first issue here! Be sure to follow the issue template!

welcome[bot] avatar Mar 14 '25 08:03 welcome[bot]

/assign

kushal9897 avatar Mar 14 '25 08:03 kushal9897

/assign

EmAchieng avatar Apr 02 '25 11:04 EmAchieng

@realshuting please review my pr

kushal9897 avatar Apr 02 '25 12:04 kushal9897

/assign

yashpal2104 avatar Jun 11 '25 08:06 yashpal2104