kubestone icon indicating copy to clipboard operation
kubestone copied to clipboard

removed the UDP option from the server cmd args

Open rinormaloku opened this issue 5 years ago • 4 comments

Creating a udp iperf3 with this operator was failing due to the cmd option added to the server-side as well --udp

Verify by checking the official docs as well: https://iperf.fr/iperf-doc.php

image

rinormaloku avatar Jan 21 '21 08:01 rinormaloku

@rinormaloku : thanks for this contribution and sorry for being late to respond here.

Your fix seems correct, but our unit test expects --udp to be there. Could u pls fix the unit test so that this could be merged?

tibkiss avatar Apr 03 '22 07:04 tibkiss

Hi @tibkiss,

I found a few more issues in this section of the code. I fixed those but pushed those to an internal repository later on but I don't have access to it anymore. So this can be disregarded.

rinormaloku avatar Apr 03 '22 08:04 rinormaloku

@rinormaloku : ouch. do you remember what other problem you found?

tibkiss avatar Apr 03 '22 09:04 tibkiss

I'll reach out to my old team, and will let you know ;))

rinormaloku avatar Apr 03 '22 10:04 rinormaloku