killbill icon indicating copy to clipboard operation
killbill copied to clipboard

Fixed item should only apply once

Open sbrossie opened this issue 6 years ago • 4 comments

Today, our FIXED items are being invoiced whenever a new Plan containing such FIXED item is active. We had some requests to make this behavior configurable and possibly disable any FIXED item when changing Plan.

sbrossie avatar Apr 08 '20 18:04 sbrossie

See #43

sbrossie avatar Apr 08 '20 18:04 sbrossie

Changing the code to exclude the generation of fixed price when changing plans should be easy to implement, this is just a matter of changing the code here to also exclude CHANGE.

However:

  • Is this a change of behavior or a configuration -- and if so how?
  • Is this only for CHANGE or does it also include TRANSFER ?

sbrossie avatar Jun 11 '21 17:06 sbrossie

See also https://github.com/killbill/killbill/issues/1395

sbrossie avatar Feb 09 '22 22:02 sbrossie

Pausing a subscription with a fixed item also causes the fixed item to be invoiced again once the subscription is resumed. Steps to reproduce:

  1. Create a subscription to a plan that has both a fixed and recurring price (See attached catalog as an example) -The invoice generated contains both a FIXED and a RECURRING invoice item.
  2. Pause the subscription - A credit is generated only corresponding to the RECURRING item
  3. Move the clock by a few days and resume the subscription - The invoice generated again contains a FIXED invoice item.

fixed-and-recurring-price-evergreen-phase.zip

reshmabidikar avatar Jul 22 '22 06:07 reshmabidikar