hono icon indicating copy to clipboard operation
hono copied to clipboard

fix(middleware): Context declaration

Open MonsterDeveloper opened this issue 1 year ago • 5 comments

Fixes #2693

@yusukebe not sure it's the best way though, as denoify automatically adds node: to hono import... Without this import TS yells that hono is an "unknown" module...

The author should do the following, if applicable

  • [ ] ~Add tests~ (n/a)
  • [x] Run tests
  • [x] bun denoify to generate files for Deno
  • [x] bun run format:fix && bun run lint:fix to format the code

MonsterDeveloper avatar May 17 '24 15:05 MonsterDeveloper

Hi @MonsterDeveloper thank you for the PR!

About the PR, can you wait for me to merge? Perhaps it will be fixed completely if Hono supports JSR.

yusukebe avatar May 18 '24 00:05 yusukebe

@MonsterDeveloper

I got it. We should extend ../.. instead of ../../context. Could you fix them?

yusukebe avatar May 18 '24 01:05 yusukebe

Oh my lovely TypeScript:)

Corrected to ../... Seems to be working too.

MonsterDeveloper avatar May 18 '24 04:05 MonsterDeveloper

But now Deno is not happy... CleanShot 2024-05-18 at 06 02 53@2x

MonsterDeveloper avatar May 18 '24 04:05 MonsterDeveloper

@MonsterDeveloper

Oh... Then, wait until this PR is merged. The next minor version may be released soon, and it will be merged at that time!

yusukebe avatar May 18 '24 09:05 yusukebe

@yusukebe hi! Seems like #2662 is merged now, can we resume the work on this PR?

MonsterDeveloper avatar May 26 '24 16:05 MonsterDeveloper

The issue was fixed. This PR is not needed. Thanks!

yusukebe avatar May 28 '24 12:05 yusukebe