flutter_image_cropper icon indicating copy to clipboard operation
flutter_image_cropper copied to clipboard

consolidating result options in an anonymous class

Open yapiskan opened this issue 3 years ago • 1 comments

Wraps the params in the results function into a class so that Croppie would properly read the format and other params. Otherwise only the type param is taken into account by Croppie library.

yapiskan avatar May 28 '22 19:05 yapiskan

Thank for your PR. It looks good to me, but I also think that we should abstract the WebSetting model as well, move all JS codes out of this model, it would help us get rid of using conditional import as the current approach. What do you think?

hnvn avatar May 31 '22 03:05 hnvn

Thanks for PR, I am going to close this because of #350

hnvn avatar Aug 20 '22 02:08 hnvn