gnxi icon indicating copy to clipboard operation
gnxi copied to clipboard

Update py_gnmicli.py for gNMI Subscribe support

Open tejaskumark opened this issue 7 years ago • 5 comments

Adding support for gNMI subscribe.

tejaskumark avatar Feb 28 '19 14:02 tejaskumark

Codecov Report

Merging #65 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #65   +/-   ##
=======================================
  Coverage   52.79%   52.79%           
=======================================
  Files          10       10           
  Lines        1197     1197           
=======================================
  Hits          632      632           
  Misses        482      482           
  Partials       83       83

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 64f55df...cdd72b5. Read the comment docs.

codecov-io avatar Feb 28 '19 14:02 codecov-io

@mike-albano Can you please help to get this merge, this has fix for xpath construction with (- and /) and also subscribe request. Thanks.

tejaskumark avatar Jun 04 '20 07:06 tejaskumark

Codecov Report

Merging #65 into master will increase coverage by 0.11%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #65      +/-   ##
==========================================
+ Coverage   52.32%   52.44%   +0.11%     
==========================================
  Files          10       12       +2     
  Lines        1204     1249      +45     
==========================================
+ Hits          630      655      +25     
- Misses        491      510      +19     
- Partials       83       84       +1     
Impacted Files Coverage Δ
gnoi/gnoi.go 63.63% <0.00%> (-3.04%) :arrow_down:
gnoi/reset/client.go 53.57% <0.00%> (ø)
gnoi/reset/server.go 66.66% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 92c6d0d...965d41d. Read the comment docs.

codecov-commenter avatar Jun 14 '20 18:06 codecov-commenter

@mike-albano Changes done. Please review. Thanks.

tejaskumark avatar Jun 14 '20 18:06 tejaskumark

@mike-albano Just to make sure this is not missed.

tejaskumark avatar Aug 28 '20 08:08 tejaskumark