sentry-android-gradle-plugin icon indicating copy to clipboard operation
sentry-android-gradle-plugin copied to clipboard

Enha: sentry-cli Integration Tests

Open denrase opened this issue 3 years ago • 1 comments

#skip-changelog

:scroll: Description

Adds integration tests to the repository for the sentry-cli commands used by this plugin.

Run locally:

test/integration-test-server-start.sh

In separate process:

export ANDROID_HOME=~/Library/Android/sdk/
export SENTRY_URL=http://127.0.0.1:8000
./gradlew -p plugin-build test --tests SentryPluginIntegrationTest
test/integration-test-server-stop.sh

:bulb: Motivation and Context

  • We want to make sure that the bundled sentry-cli version can run the used commands without issue.
  • This is still very much a work in progress, as it is not clear yet how to best run there tests on CI

:pencil: Checklist

  • [x] I reviewed the submitted code
  • [x] I added tests to verify the changes
  • [ ] I updated the docs if needed
  • [x] No breaking changes

:crystal_ball: Next steps

  • [x] Run test with CI

denrase avatar Aug 25 '22 09:08 denrase

@marandaneto do you also want to give this a review or can I just merge it?

adinauer avatar Sep 01 '22 06:09 adinauer

@marandaneto do you also want to give this a review or can I just merge it?

Feel free to merge it when there's one approval.

marandaneto avatar Sep 05 '22 09:09 marandaneto