Faker icon indicating copy to clipboard operation
Faker copied to clipboard

update use Doctrine\Common\Persistence to Doctrine\Persistence

Open etienneleba opened this issue 5 years ago • 4 comments

#2055

etienneleba avatar Sep 30 '20 12:09 etienneleba

Codecov Report

Merging #2059 into master will decrease coverage by 0.61%. The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2059      +/-   ##
============================================
- Coverage     56.56%   55.94%   -0.62%     
  Complexity     2068     2068              
============================================
  Files           306      306              
  Lines          4849     4849              
============================================
- Hits           2743     2713      -30     
- Misses         2106     2136      +30     
Impacted Files Coverage Δ Complexity Δ
src/Faker/ORM/Doctrine/ColumnTypeGuesser.php 0.00% <ø> (ø) 28.00 <0.00> (ø)
src/Faker/ORM/Doctrine/EntityPopulator.php 0.00% <ø> (ø) 50.00 <0.00> (ø)
src/Faker/ORM/Doctrine/Populator.php 0.00% <ø> (ø) 11.00 <0.00> (ø)
src/Faker/Provider/de_AT/Person.php 0.00% <0.00%> (-100.00%) 1.00% <0.00%> (ø%)
src/Faker/Provider/hr_HR/Company.php 0.00% <0.00%> (-100.00%) 1.00% <0.00%> (ø%)
src/Faker/Provider/ne_NP/Person.php 0.00% <0.00%> (-50.00%) 2.00% <0.00%> (ø%)
src/Faker/Provider/sr_RS/Address.php 66.66% <0.00%> (-33.34%) 3.00% <0.00%> (ø%)
src/Faker/Provider/en_AU/Address.php 75.00% <0.00%> (-25.00%) 4.00% <0.00%> (ø%)
src/Faker/Provider/en_IN/Address.php 50.00% <0.00%> (-25.00%) 8.00% <0.00%> (ø%)
src/Faker/Provider/es_AR/Address.php 50.00% <0.00%> (-25.00%) 4.00% <0.00%> (ø%)
... and 41 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5337ce5...899cc2d. Read the comment docs.

codecov-commenter avatar Sep 30 '20 12:09 codecov-commenter

Can we get this merged?

Alymosul avatar Oct 22 '20 13:10 Alymosul

How does this work with older Doctrine versions?

pimjansen avatar Oct 23 '20 07:10 pimjansen

No it doesn't work with oldest Doctrine versions. But those versions aren't supported anymore.

dunglas avatar Oct 23 '20 10:10 dunglas