coq icon indicating copy to clipboard operation
coq copied to clipboard

Addressing proposal #15562: cleaning API of functions for destructing/constructing abstractions or products wrt contexts

Open herbelin opened this issue 4 years ago • 4 comments

Kind: cleanup

Fixes / closes #15562

This organizes the naming of functions for destructing/constructing abstractions or products wrt contexts around the schemes "{decompose_,strip_,}{lam,prod}{_n,}{_assum,_decls,}{_red,}" and "dest{Lambda,Prod}{_red,}". See #15562 for details.

Better to merge #15453, #15524, #15565 first.

  • [x] take a decision on possibly using hnf_ (like in hnf_prod_applist) rather than _red to mean that one reduces before looking for a binder.
  • [x] keep old names with a deprecation notice? or at least document the changes
  • [ ] goes one step further in uniformization and easiness to remember by using the radical lambda rather than lam (consistently with mkLambda, destLambda etc.)

herbelin avatar Feb 01 '22 15:02 herbelin

The "needs: rebase" label was set more than 30 days ago. If the PR is not rebased in 30 days, it will be automatically closed.

coqbot-app[bot] avatar Apr 01 '22 03:04 coqbot-app[bot]

This PR was not rebased after 30 days despite the warning, it is now closed.

coqbot-app[bot] avatar May 02 '22 02:05 coqbot-app[bot]

The "needs: rebase" label was set more than 30 days ago. If the PR is not rebased in 30 days, it will be automatically closed.

coqbot-app[bot] avatar Jul 11 '22 02:07 coqbot-app[bot]

The "needs: rebase" label was set more than 30 days ago. If the PR is not rebased in 30 days, it will be automatically closed.

coqbot-app[bot] avatar Sep 22 '22 02:09 coqbot-app[bot]

The "needs: rebase" label was set more than 30 days ago. If the PR is not rebased in 30 days, it will be automatically closed.

coqbot-app[bot] avatar Nov 16 '22 02:11 coqbot-app[bot]

Are there any dependencies left to merge?

SkySkimmer avatar Dec 13 '22 13:12 SkySkimmer

Are there any dependencies left to merge?

No, I removed the label and rebased.

There was one last point to consider, namely to improve the symmetry with it_mk{Prod,Lambda,Prod_or_LetIn,...} by using the it_dest{Prod,Lambda,Prod_or_LetIn,...} pattern rather than the decompose_{prod,lambda,prod_decls,...} pattern. I don't know if developers are ready for this extra change.

herbelin avatar Dec 13 '22 15:12 herbelin

@coqbot run full ci

SkySkimmer avatar Dec 16 '22 11:12 SkySkimmer

@herbelin please link overlay PRs in the opening comment of this PR

SkySkimmer avatar Dec 16 '22 11:12 SkySkimmer

Overlay link: done

herbelin avatar Dec 16 '22 13:12 herbelin

@coqbot merge now

SkySkimmer avatar Jan 03 '23 09:01 SkySkimmer

@SkySkimmer: Please take care of the following overlays:

  • 15582-herbelin-master+cleaning-decompose_lam_n_assum-and-cie.sh

coqbot-app[bot] avatar Jan 03 '23 09:01 coqbot-app[bot]