ckeditor5 icon indicating copy to clipboard operation
ckeditor5 copied to clipboard

Consume all scopes specified in a commit instead of the first one

Open pomek opened this issue 4 years ago • 1 comments

📝 Provide a description of the new feature

There is an example of a commit that defines more than a single scope: https://github.com/ckeditor/ckeditor5/commit/7951f79

Currently, the changelog generator sorts scopes alphabetically and takes the first item, so we ended with:

* **[image](https://www.npmjs.com/package/@ckeditor/ckeditor5-image)**: Attributes from a marker conversion descriptor will be correctly added on view elements during marker downcast. Closes [#10425](https://github.com/ckeditor/ckeditor5/issues/10425). ([commit](https://github.com/ckeditor/ckeditor5/commit/7951f7994263bf73d47a5796a610fe82f05d9abe))

If a change touches more than a single package, we could extend the list of commits by copying the commit as many times as the number of defined packages in the scope and aligning the scope value to be a single package (value).

For the above package, we would end with:

* **[image](https://www.npmjs.com/package/@ckeditor/ckeditor5-image)**: Attributes from a marker conversion descriptor will be correctly added on view elements during marker downcast. Closes [#10425](https://github.com/ckeditor/ckeditor5/issues/10425). ([commit](https://github.com/ckeditor/ckeditor5/commit/7951f7994263bf73d47a5796a610fe82f05d9abe))
* **[table](https://www.npmjs.com/package/@ckeditor/ckeditor5-table)**: Attributes from a marker conversion descriptor will be correctly added on view elements during marker downcast. Closes [#10425](https://github.com/ckeditor/ckeditor5/issues/10425). ([commit](https://github.com/ckeditor/ckeditor5/commit/7951f7994263bf73d47a5796a610fe82f05d9abe))

If you'd like to see, this feature implemented, add a 👍 reaction to this post.

pomek avatar Sep 27 '21 10:09 pomek

A place to update: https://github.com/ckeditor/ckeditor5-dev/blob/master/packages/ckeditor5-dev-env/lib/release-tools/utils/transformcommitfactory.js

pomek avatar Sep 29 '21 10:09 pomek