webpack-babel-multi-target-plugin icon indicating copy to clipboard operation
webpack-babel-multi-target-plugin copied to clipboard

mini-css-extract-plugin crashes with tagAssetsWithKey

Open Austaras opened this issue 5 years ago • 2 comments

When I configured this plugin with

targets: {
        modern: true,
        legacy: {
          tagAssetsWithKey: true,
        },
      },

mini-css-extract-plugin will crash

Austaras avatar Jan 07 '21 09:01 Austaras

@Austaras can you add some more details? (stack trace, package versions, etc)

DanielSchaffer avatar Jan 12 '21 17:01 DanielSchaffer

I'm using master branch of this repo and got

ERROR in chunk main [initial]
    main.css
    Cannot read property 'pop' of undefined
    TypeError: Cannot read property 'pop' of undefined
        at MiniCssExtractPlugin.renderContentAsset (/home/chla/Code/webpack-babel-multi-target-plugin/node_modules/mini-css-extract-plugin/dist/index.js:343:44)
        at Object.render (/home/chla/Code/webpack-babel-multi-target-plugin/node_modules/mini-css-extract-plugin/dist/index.js:174:32)
        at Compilation.createChunkAssets (/home/chla/Code/webpack-babel-multi-target-plugin/node_modules/webpack/lib/Compilation.js:2035:29)
        at /home/chla/Code/webpack-babel-multi-target-plugin/node_modules/webpack/lib/Compilation.js:1359:10
        at AsyncSeriesHook.eval [as callAsync] (eval at create (/home/chla/Code/webpack-babel-multi-target-plugin/node_modules/tapable/lib/HookCodeFactory.js:33:10), <anonymous>:9:1)
        at AsyncSeriesHook.lazyCompileHook (/home/chla/Code/webpack-babel-multi-target-plugin/node_modules/tapable/lib/Hook.js:154:20)
        at Compilation.seal (/home/chla/Code/webpack-babel-multi-target-plugin/node_modules/webpack/lib/Compilation.js:1304:27)
        at /home/chla/Code/webpack-babel-multi-target-plugin/node_modules/webpack/lib/Compiler.js:665:18
        at /home/chla/Code/webpack-babel-multi-target-plugin/node_modules/webpack/lib/Compilation.js:1224:4
        at AsyncSeriesHook.eval [as callAsync] (eval at create (/home/chla/Code/webpack-babel-multi-target-plugin/node_modules/tapable/lib/HookCodeFactory.js:33:10), <anonymous>:20:1)
        at AsyncSeriesHook.lazyCompileHook (/home/chla/Code/webpack-babel-multi-target-plugin/node_modules/tapable/lib/Hook.js:154:20)
        at Compilation.finish (/home/chla/Code/webpack-babel-multi-target-plugin/node_modules/webpack/lib/Compilation.js:1216:28)
        at /home/chla/Code/webpack-babel-multi-target-plugin/node_modules/webpack/lib/Compiler.js:662:17
        at _done (eval at create (/home/chla/Code/webpack-babel-multi-target-plugin/node_modules/tapable/lib/HookCodeFactory.js:33:10), <anonymous>:9:1)
        at eval (eval at create (/home/chla/Code/webpack-babel-multi-target-plugin/node_modules/tapable/lib/HookCodeFactory.js:33:10), <anonymous>:31:22)
        at runMicrotasks (<anonymous>)

You could test with this branch

Austaras avatar Jan 12 '21 17:01 Austaras